Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jfx22u Public archive

8324337: Cherry-pick WebKit 617.1 stabilization fixes #7

Conversation

HimaBinduMeda
Copy link

@HimaBinduMeda HimaBinduMeda commented Jan 30, 2024

Clean Backport


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8324337 needs maintainer approval

Issue

  • JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx22u.git pull/7/head:pull/7
$ git checkout pull/7

Update a local copy of the PR:
$ git checkout pull/7
$ git pull https://git.openjdk.org/jfx22u.git pull/7/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7

View PR using the GUI difftool:
$ git pr show -t 7

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx22u/pull/7.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2024

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 52840a17dee6a92fb9b1f3ff1b314b0ae228b95f 8324337: Cherry-pick WebKit 617.1 stabilization fixes Jan 30, 2024
@openjdk
Copy link

openjdk bot commented Jan 30, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 30, 2024

⚠️ @HimaBinduMeda This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Jan 30, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 30, 2024

Webrevs

@kevinrushforth
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Jan 30, 2024

@kevinrushforth
8324337: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Jan 30, 2024

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324337: Cherry-pick WebKit 617.1 stabilization fixes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 30, 2024
@HimaBinduMeda
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 30, 2024

Going to push as commit a247278.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 30, 2024
@openjdk openjdk bot closed this Jan 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 30, 2024
@openjdk
Copy link

openjdk bot commented Jan 30, 2024

@HimaBinduMeda Pushed as commit a247278.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants