-
Notifications
You must be signed in to change notification settings - Fork 7
8338886: JavaFX debug builds fail on macOS #16
8338886: JavaFX debug builds fail on macOS #16
Conversation
|
👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into |
|
/approval Mac Debug build failed fix |
|
@jaybhaskar This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
@jaybhaskar usage: |
andy-goryachev-oracle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean backport
|
/approval request Keep native WebKit in sync |
|
@jaybhaskar |
|
/approve yes |
|
@kevinrushforth |
|
/integrate |
|
Going to push as commit 5a81743. |
|
@jaybhaskar Pushed as commit 5a81743. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
A clean backport to jfx23u. The fix is for a build error , failing to build on mac on debug mode.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx23u.git pull/16/head:pull/16$ git checkout pull/16Update a local copy of the PR:
$ git checkout pull/16$ git pull https://git.openjdk.org/jfx23u.git pull/16/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16View PR using the GUI difftool:
$ git pr show -t 16Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx23u/pull/16.diff
Webrev
Link to Webrev Comment