Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338886: JavaFX debug builds fail on macOS #16

Conversation

jaybhaskar
Copy link
Member

@jaybhaskar jaybhaskar commented Aug 28, 2024

A clean backport to jfx23u. The fix is for a build error , failing to build on mac on debug mode.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8338886 needs maintainer approval

Issue

  • JDK-8338886: JavaFX debug builds fail on macOS (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx23u.git pull/16/head:pull/16
$ git checkout pull/16

Update a local copy of the PR:
$ git checkout pull/16
$ git pull https://git.openjdk.org/jfx23u.git pull/16/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16

View PR using the GUI difftool:
$ git pr show -t 16

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx23u/pull/16.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 28, 2024

👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@jaybhaskar
Copy link
Member Author

/approval Mac Debug build failed fix

@openjdk
Copy link

openjdk bot commented Aug 28, 2024

@jaybhaskar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338886: JavaFX debug builds fail on macOS

Reviewed-by: angorya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 48497168892f5625f77936eccf19e836a6c1971e 8338886: JavaFX debug builds fail on macOS Aug 28, 2024
@openjdk
Copy link

openjdk bot commented Aug 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 28, 2024

⚠️ @jaybhaskar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 28, 2024
@openjdk
Copy link

openjdk bot commented Aug 28, 2024

@jaybhaskar usage: /approval [<id>] (request|cancel) [<text>]

@mlbridge
Copy link

mlbridge bot commented Aug 28, 2024

Webrevs

Copy link

@andy-goryachev-oracle andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean backport

@jaybhaskar
Copy link
Member Author

/approval request Keep native WebKit in sync

@openjdk
Copy link

openjdk bot commented Aug 28, 2024

@jaybhaskar
8338886: The approval request has been created successfully.

@kevinrushforth
Copy link
Member

/approve yes

@openjdk openjdk bot added the approval label Aug 28, 2024
@openjdk
Copy link

openjdk bot commented Aug 28, 2024

@kevinrushforth
8338886: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Aug 28, 2024
@jaybhaskar
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 29, 2024

Going to push as commit 5a81743.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 29, 2024
@openjdk openjdk bot closed this Aug 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 29, 2024
@openjdk
Copy link

openjdk bot commented Aug 29, 2024

@jaybhaskar Pushed as commit 5a81743.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants