Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8334124: Rendering issues with CSS "text-shadow" in WebView #17

Conversation

jaybhaskar
Copy link
Member

@jaybhaskar jaybhaskar commented Sep 2, 2024

A clean backport to jfx23u. The fix is for Rendering issues with CSS "text-shadow" in WebView . I have tested the fix it is working with the fix and failing without the fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8334124 needs maintainer approval

Issue

  • JDK-8334124: Rendering issues with CSS "text-shadow" in WebView (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx23u.git pull/17/head:pull/17
$ git checkout pull/17

Update a local copy of the PR:
$ git checkout pull/17
$ git pull https://git.openjdk.org/jfx23u.git pull/17/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17

View PR using the GUI difftool:
$ git pr show -t 17

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx23u/pull/17.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 2, 2024

👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 2, 2024

@jaybhaskar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334124: Rendering issues with CSS "text-shadow" in WebView

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e0ceafb7dba15b4faa683c336828e79f19a59d30 8334124: Rendering issues with CSS "text-shadow" in WebView Sep 2, 2024
@openjdk
Copy link

openjdk bot commented Sep 2, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 2, 2024

⚠️ @jaybhaskar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 2, 2024
@jaybhaskar
Copy link
Member Author

/approval request Keep native WebKit in sync

@openjdk
Copy link

openjdk bot commented Sep 2, 2024

@jaybhaskar
8334124: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 2, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 2, 2024

Webrevs

@kevinrushforth
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Sep 2, 2024

@kevinrushforth
8334124: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 2, 2024
@jaybhaskar
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 3, 2024

Going to push as commit ece461b.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 3, 2024
@openjdk openjdk bot closed this Sep 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 3, 2024
@openjdk
Copy link

openjdk bot commented Sep 3, 2024

@jaybhaskar Pushed as commit ece461b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants