-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8334124: Rendering issues with CSS "text-shadow" in WebView #17
8334124: Rendering issues with CSS "text-shadow" in WebView #17
Conversation
👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into |
@jaybhaskar This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Keep native WebKit in sync |
@jaybhaskar |
/approve yes |
@kevinrushforth |
/integrate |
Going to push as commit ece461b. |
@jaybhaskar Pushed as commit ece461b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
A clean backport to jfx23u. The fix is for Rendering issues with CSS "text-shadow" in WebView . I have tested the fix it is working with the fix and failing without the fix.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx23u.git pull/17/head:pull/17
$ git checkout pull/17
Update a local copy of the PR:
$ git checkout pull/17
$ git pull https://git.openjdk.org/jfx23u.git pull/17/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17
View PR using the GUI difftool:
$ git pr show -t 17
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx23u/pull/17.diff
Webrev
Link to Webrev Comment