Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338701: Provide media support for libavcodec version 61 #18

Conversation

sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Sep 4, 2024

Clean backport of JDK-8338701.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8338701 needs maintainer approval

Issue

  • JDK-8338701: Provide media support for libavcodec version 61 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx23u.git pull/18/head:pull/18
$ git checkout pull/18

Update a local copy of the PR:
$ git checkout pull/18
$ git pull https://git.openjdk.org/jfx23u.git pull/18/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18

View PR using the GUI difftool:
$ git pr show -t 18

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx23u/pull/18.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 4, 2024

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 4, 2024

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338701: Provide media support for libavcodec version 61

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 3483574: 8337481: File API: file.name contains path instead of name

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 6115b396bacf62f39dcaa93c7c0adcd60b428b8c 8338701: Provide media support for libavcodec version 61 Sep 4, 2024
@openjdk
Copy link

openjdk bot commented Sep 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 4, 2024

⚠️ @sashamatveev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 4, 2024
@sashamatveev
Copy link
Member Author

/approval Without support of libavcodec version 61, JavaFX Media will not work on latest Linux distributions such as Ubuntu 24.10 without manually installing older versions of libavcodec.

@openjdk
Copy link

openjdk bot commented Sep 4, 2024

@sashamatveev usage: /approval [<id>] (request|cancel) [<text>]

@mlbridge
Copy link

mlbridge bot commented Sep 4, 2024

Webrevs

@sashamatveev
Copy link
Member Author

/approval request Without support of libavcodec version 61, JavaFX Media will not work on latest Linux distributions such as Ubuntu 24.10 without manually installing older versions of libavcodec.

@openjdk
Copy link

openjdk bot commented Sep 4, 2024

@sashamatveev
8338701: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 4, 2024
@kevinrushforth
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Sep 4, 2024

@kevinrushforth
8338701: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 4, 2024
@sashamatveev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 4, 2024

Going to push as commit aba60fd.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 3483574: 8337481: File API: file.name contains path instead of name

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 4, 2024
@openjdk openjdk bot closed this Sep 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 4, 2024
@openjdk
Copy link

openjdk bot commented Sep 4, 2024

@sashamatveev Pushed as commit aba60fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants