Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337481: File API: file.name contains path instead of name #19

Conversation

Schmidor
Copy link

@Schmidor Schmidor commented Sep 4, 2024

Clean backport of JDK-8337481


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8337481 needs maintainer approval

Issue

  • JDK-8337481: File API: file.name contains path instead of name (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx23u.git pull/19/head:pull/19
$ git checkout pull/19

Update a local copy of the PR:
$ git checkout pull/19
$ git pull https://git.openjdk.org/jfx23u.git pull/19/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19

View PR using the GUI difftool:
$ git pr show -t 19

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx23u/pull/19.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 4, 2024

👋 Welcome back oschmidtmer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 4, 2024

@Schmidor This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337481: File API: file.name contains path instead of name

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport ca70a07b3ee712b1d06baf8a3901e6ae96070124 8337481: File API: file.name contains path instead of name Sep 4, 2024
@openjdk
Copy link

openjdk bot commented Sep 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 4, 2024

⚠️ @Schmidor This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 4, 2024
@Schmidor
Copy link
Author

Schmidor commented Sep 4, 2024

/approval request

@openjdk
Copy link

openjdk bot commented Sep 4, 2024

@Schmidor
8337481: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 4, 2024
@kevinrushforth
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Sep 4, 2024

@kevinrushforth
8337481: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 4, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 4, 2024

Webrevs

@Schmidor
Copy link
Author

Schmidor commented Sep 4, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 4, 2024
@openjdk
Copy link

openjdk bot commented Sep 4, 2024

@Schmidor
Your change (at version a3db959) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 4, 2024

Going to push as commit 3483574.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 4, 2024
@openjdk openjdk bot closed this Sep 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 4, 2024
@openjdk
Copy link

openjdk bot commented Sep 4, 2024

@kevinrushforth @Schmidor Pushed as commit 3483574.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants