Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328994: Update WebKit to 619.1 #4

Conversation

HimaBinduMeda
Copy link

@HimaBinduMeda HimaBinduMeda commented Jul 19, 2024

Clean Backport


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328994 needs maintainer approval

Issue

  • JDK-8328994: Update WebKit to 619.1 (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx23u.git pull/4/head:pull/4
$ git checkout pull/4

Update a local copy of the PR:
$ git checkout pull/4
$ git pull https://git.openjdk.org/jfx23u.git pull/4/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4

View PR using the GUI difftool:
$ git pr show -t 4

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx23u/pull/4.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 19, 2024

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 19, 2024

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328994: Update WebKit to 619.1

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 34bbf85362fae946c6306eb52a8478aa2ca3ef5f 8328994: Update WebKit to 619.1 Jul 19, 2024
@openjdk
Copy link

openjdk bot commented Jul 19, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 19, 2024
@HimaBinduMeda
Copy link
Author

/integrate

@mlbridge
Copy link

mlbridge bot commented Jul 19, 2024

Webrevs

  • 00: [Full](Webrev is not available because diff is too large) (ecaf596f)

@openjdk
Copy link

openjdk bot commented Jul 19, 2024

Going to push as commit eec590a.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 19, 2024
@openjdk openjdk bot closed this Jul 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 19, 2024
@openjdk
Copy link

openjdk bot commented Jul 19, 2024

@HimaBinduMeda Pushed as commit eec590a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant