Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8336277: Colors are incorrect when playing H.265/HEVC on Windows 11 #7

Conversation

sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Aug 6, 2024

  • Clean backport of JDK-8336277.

Progress

  • Change must not contain extraneous whitespace
  • JDK-8336277 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8336277: Colors are incorrect when playing H.265/HEVC on Windows 11 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx23u.git pull/7/head:pull/7
$ git checkout pull/7

Update a local copy of the PR:
$ git checkout pull/7
$ git pull https://git.openjdk.org/jfx23u.git pull/7/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7

View PR using the GUI difftool:
$ git pr show -t 7

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx23u/pull/7.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 6, 2024

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 6, 2024

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8336277: Colors are incorrect when playing H.265/HEVC on Windows 11

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 635a09c7855351eac8001b60e240c826db3a6bff 8336277: Colors are incorrect when playing H.265/HEVC on Windows 11 Aug 6, 2024
@openjdk
Copy link

openjdk bot commented Aug 6, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 6, 2024

⚠️ @sashamatveev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 6, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 6, 2024

Webrevs

@openjdk openjdk bot added the approval label Aug 6, 2024
@kevinrushforth
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Aug 6, 2024

@kevinrushforth
8336277: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Aug 6, 2024
@sashamatveev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 6, 2024

Going to push as commit d0c5cd4.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 6, 2024
@openjdk openjdk bot closed this Aug 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 6, 2024
@openjdk
Copy link

openjdk bot commented Aug 6, 2024

@sashamatveev Pushed as commit d0c5cd4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants