8367602: Regression: TabPane with wrapped label calculates wrong initial size

[hjohn]

---

Progress

• Change must not contain extraneous whitespace
• JDK-8367602 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8367602: Regression: TabPane with wrapped label calculates wrong initial size (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx25u.git pull/13/head:pull/13
$ git checkout pull/13

Update a local copy of the PR:
$ git checkout pull/13
$ git pull https://git.openjdk.org/jfx25u.git pull/13/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13

View PR using the GUI difftool:
$ git pr show -t 13

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx25u/pull/13.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jhendrikx! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hjohn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367602: Regression: TabPane with wrapped label calculates wrong initial size

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 8c84c38: 8361893: Update libxml2 to 2.14.5

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @hjohn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (795e5323)

[kevinrushforth]

@hjohn For JavaFX update releases such as jfx25u, you need to request Maintainer approval by using the /approval request command. Then I'll approve it.

[hjohn]

/approval request

[openjdk]

@hjohn
8367602: The approval request has been created successfully.

[kevinrushforth]

/approve yes

[openjdk]

@kevinrushforth
8367602: The approval request has been approved.

[kevinrushforth]

Approved to integrate.

[hjohn]

/integrate

[openjdk]

Going to push as commit 5082157.
Since your change was applied there has been 1 commit pushed to the master branch:

• 8c84c38: 8361893: Update libxml2 to 2.14.5

Your commit was automatically rebased without conflicts.

[openjdk]

@hjohn Pushed as commit 5082157.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.