Skip to content

8370632: Additional libxslt 1.1.43 fixes#28

Closed
HimaBinduMeda wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-HimaBinduMeda-478e1ad4-master
Closed

8370632: Additional libxslt 1.1.43 fixes#28
HimaBinduMeda wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-HimaBinduMeda-478e1ad4-master

Conversation

@HimaBinduMeda
Copy link

@HimaBinduMeda HimaBinduMeda commented Oct 28, 2025

clean Backport


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8370632 needs maintainer approval

Issue

  • JDK-8370632: Additional libxslt 1.1.43 fixes (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx25u.git pull/28/head:pull/28
$ git checkout pull/28

Update a local copy of the PR:
$ git checkout pull/28
$ git pull https://git.openjdk.org/jfx25u.git pull/28/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28

View PR using the GUI difftool:
$ git pr show -t 28

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx25u/pull/28.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2025

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@HimaBinduMeda
Copy link
Author

/approval request Clean Backport. This is needed to maintain same webkit code across all repos

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370632: Additional libxslt 1.1.43 fixes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 478e1ad43b2feaa4fa1d5be656b78cadf2316ba3 8370632: Additional libxslt 1.1.43 fixes Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

⚠️ @HimaBinduMeda This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@HimaBinduMeda
8370632: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 28, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 28, 2025

Webrevs

@kevinrushforth
Copy link
Member

/skara approve yes

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@kevinrushforth
8370632: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 28, 2025
@HimaBinduMeda
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

Going to push as commit 2d80788.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 28, 2025
@openjdk openjdk bot closed this Oct 28, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@HimaBinduMeda Pushed as commit 2d80788.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants

Comments