Skip to content

8154847: Rendering is incorrect or not visible with StageStyle.UNIFIED on some graphics cards#6

Closed
crschnick wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-crschnick-28bde153-master
Closed

8154847: Rendering is incorrect or not visible with StageStyle.UNIFIED on some graphics cards#6
crschnick wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-crschnick-28bde153-master

Conversation

@crschnick
Copy link
Member

@crschnick crschnick commented Feb 5, 2026

Hi all,

This pull request contains a backport of commit 28bde153 from the openjdk/jfx repository.

The commit being backported was authored by Christopher Schnick on 5 Feb 2026 and was reviewed by Lukasz Kostyra and Kevin Rushforth.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8154847 needs maintainer approval

Issue

  • JDK-8154847: Rendering is incorrect or not visible with StageStyle.UNIFIED on some graphics cards (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx26u.git pull/6/head:pull/6
$ git checkout pull/6

Update a local copy of the PR:
$ git checkout pull/6
$ git pull https://git.openjdk.org/jfx26u.git pull/6/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6

View PR using the GUI difftool:
$ git pr show -t 6

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx26u/pull/6.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 5, 2026

👋 Welcome back crschnick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 5, 2026

@crschnick This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8154847: Rendering is incorrect or not visible with StageStyle.UNIFIED on some graphics cards

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • c3abe59: Merge
  • cb6b858: 8375466: Metal rendering pipeline crashes on virtualized OS
  • 3c82487: 8373936: RichEditorDemoApp enhancements

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 28bde153cbf960e1b8d74d258ba351a5305f124b 8154847: Rendering is incorrect or not visible with StageStyle.UNIFIED on some graphics cards Feb 5, 2026
@openjdk
Copy link

openjdk bot commented Feb 5, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 5, 2026
@openjdk
Copy link

openjdk bot commented Feb 5, 2026

⚠️ @crschnick This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 5, 2026
@crschnick
Copy link
Member Author

/approval

@openjdk
Copy link

openjdk bot commented Feb 5, 2026

@crschnick usage: /approval [<id>] (request|cancel) [<text>]

@mlbridge
Copy link

mlbridge bot commented Feb 5, 2026

Webrevs

@kevinrushforth
Copy link
Member

@crschnick As Skara notes, you forgot the "request" modifier for the "approval" command. Something like this is what you will need: /approval request REASON YOU THINK IT SHOULD BE BACKPORTED (and don't worry much about the reason...we already discussed it on the PR and I'll approve it once you make the request).

@crschnick
Copy link
Member Author

/approval request This JBS issue has seen a lot of activity over the years, so there is probably demand for it

@openjdk
Copy link

openjdk bot commented Feb 6, 2026

@crschnick
8154847: The approval request has been created successfully.

@crschnick
Copy link
Member Author

In general, how for can backporting go? I would argue this fix has even more relevance for older applications and JavaFX runtimes. If you are running older applications on older hardware, there is a higher change the application uses UNIFIED than now and also a higher chance that the bug occurs on older systems

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Feb 6, 2026
@kevinrushforth
Copy link
Member

Approved. Since this is a clean backport, it only needs Maintainer approval. Review is optional (and not needed in this case). Once the approval is recorded, you may integrate it.

/approve yes

@openjdk
Copy link

openjdk bot commented Feb 6, 2026

@kevinrushforth
8154847: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 6, 2026
@kevinrushforth
Copy link
Member

In general, how for can backporting go? I would argue this fix has even more relevance for older applications and JavaFX runtimes. If you are running older applications on older hardware, there is a higher change the application uses UNIFIED than now and also a higher chance that the bug occurs on older systems

That would be up to the maintainer of each code line. Gluon maintains jfx25u and jfx17u, so @johanvos is the approver. Feel free to make the request and he will decide.

There is currently no maintainer for the the OpenJFX 11u or 8u code lines. The jfx11u repo has been archived and we never created a jfx8u GitHub repo (that code line had no maintainer when we moved from Mercurial to git).

@crschnick
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 9, 2026
@openjdk
Copy link

openjdk bot commented Feb 9, 2026

@crschnick
Your change (at version 1d0c86a) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

@crschnick I completely missed that this was waiting for a sponsor. I'll do that now.

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 24, 2026

Going to push as commit 89e4d11.
Since your change was applied there have been 7 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 24, 2026
@openjdk openjdk bot closed this Feb 24, 2026
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Feb 24, 2026
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 24, 2026
@openjdk
Copy link

openjdk bot commented Feb 24, 2026

@kevinrushforth @crschnick Pushed as commit 89e4d11.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants