Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7210: Create icon for the agent (and agent plug-in) #3

Closed
wants to merge 1 commit into from

Conversation

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Mar 25, 2021

The idraw format might be a bit arbitrary, but that's what I used for this.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7210: Create icon for the agent (and agent plug-in)

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc-graphics pull/3/head:pull/3
$ git checkout pull/3

To update a local copy of the PR:
$ git checkout pull/3
$ git pull https://git.openjdk.java.net/jmc-graphics pull/3/head

@thegreystone thegreystone requested a review from aptmac Mar 25, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 25, 2021

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 25, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 25, 2021

Webrevs

aptmac
aptmac approved these changes Mar 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 26, 2021

@thegreystone This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7210: Create icon for the agent (and agent plug-in)

Reviewed-by: aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 26, 2021
@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Mar 26, 2021

/integrate

@openjdk openjdk bot closed this Mar 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 26, 2021

@thegreystone Since your change was applied there have been 2 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit f16156d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants