Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.
/ jmc-graphics Public archive

7453: Add heat map icon #7

Closed
wants to merge 1 commit into from

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Nov 25, 2021

For cimi's heat map view.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc-graphics pull/7/head:pull/7
$ git checkout pull/7

Update a local copy of the PR:
$ git checkout pull/7
$ git pull https://git.openjdk.java.net/jmc-graphics pull/7/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7

View PR using the GUI difftool:
$ git pr show -t 7

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc-graphics/pull/7.diff

@thegreystone thegreystone requested review from Gunde and aptmac November 25, 2021 14:21
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 25, 2021

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 25, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 25, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 25, 2021

@thegreystone This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7453: Add heat map icon

Reviewed-by: aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 25, 2021
@thegreystone
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 25, 2021

Going to push as commit bd34acb.

@openjdk openjdk bot closed this Nov 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 25, 2021
@openjdk
Copy link

openjdk bot commented Nov 25, 2021

@thegreystone Pushed as commit bd34acb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

2 participants