7194: No local JVMs found message could be more helpful

Reviewed-by: hirt
openjdk · Apr 12, 2021 · 84fc937 · 84fc937
1 parent f25df12
commit 84fc937
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/....openjdk.jmc.browser/src/main/resources/org/openjdk/jmc/browser/views/messages.properties b/....openjdk.jmc.browser/src/main/resources/org/openjdk/jmc/browser/views/messages.properties
@@ -57,7 +57,7 @@ JVMBrowserView_NO_LOCAL_JVMS_TITLE=No local JVMs detected
 JVMBrowserView_NO_LOCAL_JVMS_MESSAGE=No local (attachable) JVMs were detected, not even the JVM running this instance of JDK Mission Control.
 # JVMBrowserView_NO_LOCAL_JVMS_WARN_CAUSE has newlines placed so that the rows doesn't get too long. It would be
 # great if the translation also contains newlines so the rows get about the same length.
-JVMBrowserView_NO_LOCAL_JVMS_WARN_CAUSE=Local JVMs will not be detected if the JDK Mission Control Client is run with a JRE instead of a JDK, or if the hsperfdata_<user> folder in TMP is not writable. See the FAQ help section for more information.
+JVMBrowserView_NO_LOCAL_JVMS_WARN_CAUSE=Local JVMs will not be detected if the JDK Mission Control Client is run with a JRE instead of a JDK, if the JDK is <11, or if the hsperfdata_<user> folder in TMP is not writable. See the FAQ help section for more information.
 JVMBrowserView_NO_LOCAL_JVMS_WARN_PREFERENCE=Warn when no local JVMs are detected
 JVMBrowserView_COMMAND_LINE=Command Line
 JVMBrowserView_TOOLTIP_PID=Process ID

diff --git a/application/org.openjdk.jmc.docs/html/GUID-3EC7E6C3-6A64-4659-B99E-CA675A9F6E0A.htm b/application/org.openjdk.jmc.docs/html/GUID-3EC7E6C3-6A64-4659-B99E-CA675A9F6E0A.htm
@@ -79,6 +79,8 @@ <h1 id="JMCOH-GUID-3EC7E6C3-6A64-4659-B99E-CA675A9F6E0A" class="sect1"><span cla
 </li>
 <li><p>Make sure that there is a directory named <code>hsperfdata_<span class="codeinlineitalic">username</span></code> in the system's <code>tmp</code> directory, that it is writable by the user running JMC, and that the file system supports access control lists (ACLs).</p>
 </li>
+<li><p>Make sure you are running Mission Control on JDK version 11 or greater. You can set the JDK bin directory either by&#160;<tt>PATH</tt>&#160;environment variable, or by adding&#160;<tt>-vm</tt>&#160;parameter to&#160;<tt>jmc.ini</tt>&#160;file (must be inserted before&#160;<tt>-vmargs</tt>&#160;section).</p>
+</li>
 </ul>
 </div>
 <!-- class="section" -->
-Original file line number
+Diff line change
@@ Expand Up @@
     </li>
     <li><p>Make sure that there is a directory named <code>hsperfdata_<span class="codeinlineitalic">username</span></code> in the system's <code>tmp</code> directory, that it is writable by the user running JMC, and that the file system supports access control lists (ACLs).</p>
     </li>
+    <li><p>Make sure you are running Mission Control on JDK version 11 or greater. You can set the JDK bin directory either by&#160;<tt>PATH</tt>&#160;environment variable, or by adding&#160;<tt>-vm</tt>&#160;parameter to&#160;<tt>jmc.ini</tt>&#160;file (must be inserted before&#160;<tt>-vmargs</tt>&#160;section).</p>
+    </li>
     </ul>
     </div>
     <!-- class="section" -->
@@ Expand Down @@