Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6887: Agent instrumentation fails silently if method descriptors don't match #105

Closed
wants to merge 1 commit into from

Conversation

@Josh-Matsuoka
Copy link
Collaborator

@Josh-Matsuoka Josh-Matsuoka commented Aug 19, 2020

Hi,

This PR addresses JMC-6887. Currently when the agent is given an XML description that has an otherwise correct probe definition, but an incorrect method descriptor the instrumentation will inject the event classes but not the method, essentially failing silently.

The JFRTransformDescriptor will now track whether the ClassVisitor has found a matching method or not, and in the event that the ClassVisitor reaches the end of the class without finding a matching method it will log a warning to the user that no matching method was found. This will also catch the case where a non-existent method is specified for instrumentation, which will currently fail silently in the same way.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6887: Agent Instrumentation fails silently if method descriptors don't match

Reviewers

  • Marcus Hirt (hirt - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jmc pull/105/head:pull/105
$ git checkout pull/105

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 19, 2020

👋 Welcome back jmatsuoka! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Aug 19, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 19, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Aug 20, 2020

@Josh-Matsuoka This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6887: Agent instrumentation fails silently if method descriptors don't match

Reviewed-by: hirt
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • f157e54: 6875: Add agent MXBean operation to return instrumented xml configuration

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate f157e54f7e2abe2495333353f76d0f34f6ed0db6.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 20, 2020
@Josh-Matsuoka
Copy link
Collaborator Author

@Josh-Matsuoka Josh-Matsuoka commented Aug 20, 2020

/integrate

@openjdk openjdk bot closed this Aug 20, 2020
@openjdk openjdk bot added integrated and removed ready labels Aug 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 20, 2020

@Josh-Matsuoka The following commits have been pushed to master since your change was applied:

  • f157e54: 6875: Add agent MXBean operation to return instrumented xml configuration

Your commit was automatically rebased without conflicts.

Pushed as commit 76d656c.

@openjdk openjdk bot removed the rfr label Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants