Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6898: Installing from IDE update site complains about missing LZ4 plug-in #107

Closed

Conversation

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Sep 2, 2020

This is due to the LZ4 plug-in not included in the appropriate features.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6898: Installing from IDE update site complains about missing LZ4 plug-in

Reviewers

  • Guru Hb (ghb - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jmc pull/107/head:pull/107
$ git checkout pull/107

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 2, 2020

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Sep 2, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 2, 2020

Webrevs

@guruhb
guruhb approved these changes Sep 2, 2020
Copy link
Collaborator

@guruhb guruhb left a comment

Looks good to me

@openjdk
Copy link

@openjdk openjdk bot commented Sep 2, 2020

@thegreystone This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6898: Installing from IDE update site complains about missing LZ4 plug-in

Reviewed-by: ghb
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate db64b84a7b43fd52f96ef246297905f58d9eb152.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 2, 2020
@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Sep 2, 2020

/integrate

@openjdk openjdk bot closed this Sep 2, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 2, 2020

@thegreystone
Pushed as commit d0be216.

@thegreystone thegreystone deleted the thegreystone:fixing-ide-updatesite branch Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants