Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6882: Method Profiling lacks icon in the Java Application View #109

Closed
wants to merge 1 commit into from

Conversation

@guruhb
Copy link
Collaborator

@guruhb guruhb commented Sep 14, 2020

Root Cause : Image Should not be disposed outside the ImageDataProvider scope.
Solution : Image are created inside the ImageDataProvider (inside the lambda expression).


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6882: Method Profiling lacks icon in the Java Application View

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/109/head:pull/109
$ git checkout pull/109

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 14, 2020

👋 Welcome back ghb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 14, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 14, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@guruhb This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

6882: Method Profiling lacks icon in the Java Application View

Reviewed-by: hirt
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate ea46b653e1bbbafff8e72eb4bffcc6e6c4974b40.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 14, 2020
@guruhb
Copy link
Collaborator Author

@guruhb guruhb commented Sep 15, 2020

/integrate

@openjdk openjdk bot closed this Sep 15, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@guruhb Pushed as commit 16513ca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@guruhb guruhb deleted the 6882 branch Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants