Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6766: Add heap usage before and after GC to the Garbage Collections table #112

Closed
wants to merge 3 commits into from

Conversation

@jpbempel
Copy link
Member

@jpbempel jpbempel commented Sep 28, 2020

Columns are hidden for now

Here some screenshots of the changes:

JMC_UsedHeapBeforeAfterGC

JMC_UsedHeapBeforeAfterGCColumns


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6766: Add heap usage before and after GC to the Garbage Collections table

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/112/head:pull/112
$ git checkout pull/112

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 28, 2020

👋 Welcome back jpbempel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 28, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 28, 2020

Webrevs

@jpbempel jpbempel changed the title 6766: Add heap usage before and after GC to the GC table 6766: Add heap usage before and after GC to the Garbage Collections table Sep 28, 2020
@@ -295,6 +295,8 @@ GarbageCollectionsPage_ROW_METASPACE_DESC=This lane can show various metaspace r
GarbageCollectionsPage_ROW_PAUSE_PHASES=Pause Phases
GarbageCollectionsPage_ROW_PAUSE_PHASES_DESC=Phases of the garbage collection pauses
GarbageCollectionsPage_TIMELINE_SELECTION=Garbage Collections Timeline Selection
GarbageCollectionsPage_USED_HEAP_AFTERGC=Used Heap After GC
Copy link
Member

@thegreystone thegreystone Sep 29, 2020

Underscore between AFTER and GC, and BEFORE and GC. See e.g. HEAP_SUMMARY_BEFORE_GC. Otherwise all looks fine! 👍

@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2020

@jpbempel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

6766: Add heap usage before and after GC to the Garbage Collections table

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • a63a706: 6909: Upgrade to Eclipse 2020-09

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 1, 2020
@@ -315,6 +319,10 @@ void setRefCount(Object type, Object count) {
columns.add(new ColumnBuilder(t.localizedName, "ReferenceStatisticsType-" + t.name(), //$NON-NLS-1$
o -> ((GC) o).getRefCount(t)).style(SWT.RIGHT).build());
}
columns.add(new ColumnBuilder(Messages.GarbageCollectionsPage_USED_HEAP_BEFOREGC, "usedHeapBegoreGC", //$NON-NLS-1$
Copy link
Member

@thegreystone thegreystone Oct 1, 2020

Forgot to update these.

@thegreystone thegreystone self-requested a review Oct 1, 2020
@thegreystone thegreystone removed the ready label Oct 1, 2020
@jpbempel
Copy link
Member Author

@jpbempel jpbempel commented Oct 2, 2020

/integrate

@openjdk openjdk bot added the sponsor label Oct 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 2, 2020

@jpbempel
Your change (at version 6c82cdb) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Oct 2, 2020

/sponsor

@openjdk openjdk bot closed this Oct 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 2, 2020

@thegreystone @jpbempel Since your change was applied there has been 1 commit pushed to the master branch:

  • a63a706: 6909: Upgrade to Eclipse 2020-09

Your commit was automatically rebased without conflicts.

Pushed as commit 97f4d9f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants