Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6914: Fix windows check formatting script #114

Closed
wants to merge 3 commits into from

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Oct 2, 2020

because mvn is itself a script we need to call with call command
to get control back to the main script


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6914: Fix windows check formatting script

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/114/head:pull/114
$ git checkout pull/114

because mvn is itself a script we need to call with call command
to get control back to the main sript
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2020

👋 Welcome back jpbempel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 2, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2020

Webrevs

@thegreystone
Copy link
Member

thegreystone commented Oct 2, 2020

Updated the bug with some additional thoughts:
https://bugs.openjdk.java.net/browse/JMC-6914

@jpbempel
Copy link
Member Author

jpbempel commented Oct 3, 2020

Added the exit on failed calls

Copy link
Member

@thegreystone thegreystone left a comment

Would you perhaps want different fail codes for different fails?

@openjdk
Copy link

openjdk bot commented Oct 4, 2020

@jpbempel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

6914: Fix windows check formatting script

Reviewed-by: hirt, ghb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 581a13f: 6908: Rule for warning about the starting of processes
  • 62ed0e8: 6905: Add rule for heap dumps
  • 97f4d9f: 6766: Add heap usage before and after GC to the Garbage Collections table
  • a63a706: 6909: Upgrade to Eclipse 2020-09

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone, @guruhb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 4, 2020
@jpbempel
Copy link
Member Author

jpbempel commented Oct 4, 2020

Fine by me :)

guruhb
guruhb approved these changes Oct 6, 2020
@jpbempel
Copy link
Member Author

jpbempel commented Oct 6, 2020

/integrate

@openjdk openjdk bot added the sponsor label Oct 6, 2020
@openjdk
Copy link

openjdk bot commented Oct 6, 2020

@jpbempel
Your change (at version 15c317a) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

thegreystone commented Oct 6, 2020

/sponsor

@openjdk openjdk bot closed this Oct 6, 2020
@openjdk
Copy link

openjdk bot commented Oct 6, 2020

@thegreystone @jpbempel Since your change was applied there have been 4 commits pushed to the master branch:

  • 581a13f: 6908: Rule for warning about the starting of processes
  • 62ed0e8: 6905: Add rule for heap dumps
  • 97f4d9f: 6766: Add heap usage before and after GC to the Garbage Collections table
  • a63a706: 6909: Upgrade to Eclipse 2020-09

Your commit was automatically rebased without conflicts.

Pushed as commit 1250b52.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants