Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6916: JOverflow treemap listener depending on internal SWT class #116

Closed
wants to merge 1 commit into from

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Oct 2, 2020

Also removing unused constant.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6916: JOverflow treemap listener depending on internal SWT class

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/116/head:pull/116
$ git checkout pull/116

@thegreystone thegreystone requested a review from aptmac October 2, 2020 21:59
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2020

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 2, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 5, 2020

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

6916: JOverflow treemap listener depending on internal SWT class

Reviewed-by: aptmac, ghb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 581a13f: 6908: Rule for warning about the starting of processes
  • 62ed0e8: 6905: Add rule for heap dumps

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 5, 2020
@thegreystone
Copy link
Member Author

/reviewers 2

@openjdk
Copy link

openjdk bot commented Oct 5, 2020

@thegreystone
The number of required reviews for this PR is now set to 2 (with at least 1 of role committers).

@openjdk openjdk bot removed the ready label Oct 5, 2020
@openjdk openjdk bot added the ready label Oct 6, 2020
@thegreystone
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Oct 6, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 6, 2020
@openjdk
Copy link

openjdk bot commented Oct 6, 2020

@thegreystone Since your change was applied there have been 6 commits pushed to the master branch:

  • c3b53e6: 6917: Clean warnings in the agent project
  • e74a5ff: 6837: More formal tone in the agent settings
  • d308b07: 6899: Upgrade core to 8
  • 1250b52: 6914: Fix windows check formatting script
  • 581a13f: 6908: Rule for warning about the starting of processes
  • 62ed0e8: 6905: Add rule for heap dumps

Your commit was automatically rebased without conflicts.

Pushed as commit 63f3b35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the 6916-internal-swt branch October 6, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants