Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6837: More formal tone in the agent settings #118

Closed

Conversation

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Oct 2, 2020

Wasn't as bad as I remembered it.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6837: More formal tone in the agent settings

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/118/head:pull/118
$ git checkout pull/118

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 2, 2020

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 2, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 2, 2020

Webrevs

@thegreystone thegreystone requested a review from guruhb Oct 5, 2020
@guruhb
guruhb approved these changes Oct 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

6837: More formal tone in the agent settings

Reviewed-by: ghb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 581a13f: 6908: Rule for warning about the starting of processes
  • 62ed0e8: 6905: Add rule for heap dumps

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 6, 2020
@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Oct 6, 2020

/integrate

@openjdk openjdk bot closed this Oct 6, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@thegreystone Since your change was applied there have been 4 commits pushed to the master branch:

  • d308b07: 6899: Upgrade core to 8
  • 1250b52: 6914: Fix windows check formatting script
  • 581a13f: 6908: Rule for warning about the starting of processes
  • 62ed0e8: 6905: Add rule for heap dumps

Your commit was automatically rebased without conflicts.

Pushed as commit e74a5ff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the thegreystone:6837-settings-cleanup branch Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants