-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6846: Parser needs to skip events with no metadata #128
6846: Parser needs to skip events with no metadata #128
Conversation
👋 Welcome back hirt! A progress list of the required criteria for merging this PR into |
Webrevs
|
...ghtrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/TypeManager.java
Outdated
Show resolved
Hide resolved
Strictly speaking, I could skip sending in the event size now. Then again, I'll need that for next iteration, so I'll leave it in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
@thegreystone This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@thegreystone Pushed as commit fea3cc6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Also fixing some javadoc errors.
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jmc pull/128/head:pull/128
$ git checkout pull/128