Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6846: Parser needs to skip events with no metadata #128

Closed

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Oct 12, 2020

Also fixing some javadoc errors.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

linux mac win
Build / test ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (1/1 passed)

Issue

  • JMC-6846: Parser needs to skip events with no metadata

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/128/head:pull/128
$ git checkout pull/128

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2020

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 12, 2020
@thegreystone thegreystone changed the title 6846 skip events no metadata 6846: Parser needs to skip events with no metadata Oct 12, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2020

Webrevs

@thegreystone
Copy link
Member Author

thegreystone commented Oct 13, 2020

Strictly speaking, I could skip sending in the event size now. Then again, I'll need that for next iteration, so I'll leave it in.

@thegreystone thegreystone requested a review from egahlin October 13, 2020 11:00
Copy link
Member

@egahlin egahlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!

@thegreystone thegreystone requested a review from egahlin October 13, 2020 20:53
Copy link
Member

@egahlin egahlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@thegreystone thegreystone requested a review from egahlin October 14, 2020 11:11
@openjdk
Copy link

openjdk bot commented Oct 14, 2020

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6846: Parser needs to skip events with no metadata

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 14, 2020
@thegreystone
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Oct 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 14, 2020
@openjdk
Copy link

openjdk bot commented Oct 14, 2020

@thegreystone Pushed as commit fea3cc6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the 6846-skip-events-no-metadata branch October 15, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants