Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6542: Improve calls to render in the flame view #133

Conversation

mirage22
Copy link
Collaborator

@mirage22 mirage22 commented Oct 18, 2020

the Flameview shift fix during a fast scrolling over the selections: https://bugs.openjdk.java.net/browse/JMC-6542


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6542: Improve calls to render in the flame view

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/133/head:pull/133
$ git checkout pull/133

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2020

👋 Welcome back mwengner! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mirage22
Copy link
Collaborator Author

@openjdk openjdk bot added the rfr label Oct 18, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2020

@openjdk
Copy link

openjdk bot commented Oct 20, 2020

@mirage22 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6542: Improve calls to render in the flame view

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 45449e9: 6911: Third Party Upgrade to HdrHistogram 2.1.12

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 20, 2020
@mirage22
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot closed this Oct 20, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 20, 2020
@openjdk
Copy link

openjdk bot commented Oct 20, 2020

@mirage22 Since your change was applied there has been 1 commit pushed to the master branch:

  • 45449e9: 6911: Third Party Upgrade to HdrHistogram 2.1.12

Your commit was automatically rebased without conflicts.

Pushed as commit 16b3685.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants