Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6986: "Flight Recorder" is not working as expected for localhost Connection #181

Closed
wants to merge 2 commits into from

Conversation

guruhb
Copy link
Collaborator

@guruhb guruhb commented Dec 14, 2020

RC : "Unlock Commercial Feature " Dialog was promoted while Using : Oracle JDK 11.0.x + Local rmi connection (Not for OpenJDK 11 or above).
Solution : Check if the target JVM is Oracle JDK and its version is greater than or equal to 11.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6986: "Flight Recorder" is not working as expected for localhost Connection

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/181/head:pull/181
$ git checkout pull/181

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2020

👋 Welcome back ghb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@guruhb guruhb changed the title "Flight Recorder" is not working as expected for localhost Connection 6986: "Flight Recorder" is not working as expected for localhost Connection Dec 14, 2020
@openjdk openjdk bot added the rfr label Dec 14, 2020
@openjdk
Copy link

openjdk bot commented Dec 14, 2020

@guruhb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6986: "Flight Recorder" is not working as expected for localhost Connection

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 14, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 14, 2020

Webrevs

@guruhb
Copy link
Collaborator Author

guruhb commented Dec 14, 2020

/integrate

@openjdk openjdk bot closed this Dec 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 14, 2020
@openjdk
Copy link

openjdk bot commented Dec 14, 2020

@guruhb Pushed as commit 1ec1c33.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@guruhb guruhb deleted the 6986 branch June 7, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants