Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7062: Update to the Eclipse 2020-12 platform #185

Closed

Conversation

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Dec 16, 2020

Also updating the babel bundles for the 2020-09 platform.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7062: Update to the Eclipse 2020-12 platform

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/185/head:pull/185
$ git checkout pull/185

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 16, 2020

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@thegreystone thegreystone changed the title 7062: Updating platform to 2020-12 7062: Update to the Eclipse 2020-12 platform Dec 16, 2020
@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Dec 17, 2020

@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Dec 17, 2020

Seems the problem has now been fixed on the Eclipse site. Re-running tests.

@thegreystone thegreystone marked this pull request as ready for review Dec 17, 2020
@openjdk openjdk bot added the rfr label Dec 17, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 17, 2020

Webrevs

@thegreystone thegreystone requested review from guruhb and aptmac Dec 17, 2020
@aptmac
Copy link
Member

@aptmac aptmac commented Dec 18, 2020

From a testing perspective, I opened https://bugs.openjdk.java.net/browse/JMC-7068 today, where JfrRecordingTest hangs on Fedora after the 2020-09 update, and it continues with this 2020-12 patch.

On the first run of uitests I only ran JfrRecordingTest to see if it'd hang, and it did.

The second time I ran the uitests I had a test failure in console.ui.FreezeTableTest:

Errors: 
  FreezeTableTest.freeze:82 » IndexOutOfBounds Index 0 out of bounds for length ...

On the third run, it SIGSEGV'd at org.openjdk.jmc.flightrecorder.uitest.ControlRecordingsTest.

On the fourth run I ran only the tests under flightrecorder.uitest (without JfrRecordingTest), and made it through okay.

From a review perspective, I'm not sure how to review this one. Dependency freeze (if I'm recalling correctly) was supposed to be on pace with rampdown 1 on November 23rd, so I might have to defer to @jiekang for more insight this one, but the eclipse fedora rpm repo was recently updated to 2020-09 (4.17.0).. so I'm not sure if an extra update 2020-12 will impact a hopeful jmc release timeline on our side.

@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Dec 18, 2020

Oracle has already stated that they are considering releasing on 2020-06 (@guruhb - is this still the case?). Even if we take it (it does contain Big Sur-related fixes), vendors can decide which version they want to build and release on (i.e. -P<platform> when packaging).

@jiekang
Copy link
Collaborator

@jiekang jiekang commented Dec 18, 2020

Yes, as downstream we can select a different release if need be; well it isn't necessarily in our hands with Fedora but anyways.

@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Dec 18, 2020

After playing around a bit more, there seems to be some problem with the Chromium based browser component on Windows when using 2020-12. I'm withdrawing this for now - the big sur fixes will have to wait.

@thegreystone thegreystone marked this pull request as draft Dec 18, 2020
@openjdk openjdk bot removed the rfr label Dec 18, 2020
@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Dec 21, 2020

Might want to take this, but keep 2020-09 as a default, for two reasons:

  1. It makes it easier for people to try 2020-12 based builds (override with -P2020-12).
  2. It uses the most recent babel release.

@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Dec 21, 2020

This might be the reason for the problems on 2020-12:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=569039

@thegreystone thegreystone marked this pull request as ready for review Dec 21, 2020
@openjdk openjdk bot added the rfr label Dec 21, 2020
@thegreystone thegreystone requested a review from jiekang Dec 22, 2020
guruhb
guruhb approved these changes Dec 29, 2020
Copy link
Collaborator

@guruhb guruhb left a comment

Looks good to me

@openjdk
Copy link

@openjdk openjdk bot commented Dec 29, 2020

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7062: Update to the Eclipse 2020-12 platform

Reviewed-by: jkang, ghb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 2ede603: 7000: Update third party library used in flightrecorder.flameview
  • 46a5590: 7052: The link to BellSoft LMC should be updated

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 29, 2020
@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Dec 31, 2020

/integrate

@openjdk openjdk bot closed this Dec 31, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 31, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 31, 2020

@thegreystone Since your change was applied there have been 2 commits pushed to the master branch:

  • 2ede603: 7000: Update third party library used in flightrecorder.flameview
  • 46a5590: 7052: The link to BellSoft LMC should be updated

Your commit was automatically rebased without conflicts.

Pushed as commit a6d85ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the 7062-platform-update-2020-12 branch Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants