Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7000: Update third party library used in flightrecorder.flameview #186

Closed
wants to merge 3 commits into from

Conversation

guruhb
Copy link
Collaborator

@guruhb guruhb commented Dec 20, 2020

Updated below listed third party library used in flameview

  1. d3.js (v6.3.1) : Updated Copyright notice in THIRDPARTYREADME.txt from https://raw.githubusercontent.com/d3/d3/master/LICENSE
  2. d3-flamegraph (v4.0.6)
  3. d3-flamegraph-tooltip (v4.0.6) : Replaced d3-tip which is currently archived.

Note: minified version (2) and (3) doesn't render Flameview as expected, Tried debugging in Chrome with page.templated formatted and got console error "Uncaught TypeError: Cannot read property 'defaultFlamegraphTooltip' of undefined ... "

Tested on Windows, Mac OS and Ubuntu.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7000: Update third party library used in flightrecorder.flameview

Reviewers

Contributors

  • Miro Wengner <miro.wengner@gmail.com>

Download

$ git fetch https://git.openjdk.java.net/jmc pull/186/head:pull/186
$ git checkout pull/186

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2020

👋 Welcome back ghb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 20, 2020
@guruhb
Copy link
Collaborator Author

guruhb commented Dec 20, 2020

/contributor mirage22

@openjdk
Copy link

openjdk bot commented Dec 20, 2020

@guruhb Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@mlbridge
Copy link

mlbridge bot commented Dec 20, 2020

Webrevs

@guruhb
Copy link
Collaborator Author

guruhb commented Dec 20, 2020

/contributor add [@mirage22 ]

@openjdk
Copy link

openjdk bot commented Dec 20, 2020

@guruhb Could not parse mirage22 as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@guruhb
Copy link
Collaborator Author

guruhb commented Dec 20, 2020

/contributor add [@mirage22 ]

@openjdk
Copy link

openjdk bot commented Dec 20, 2020

@guruhb Could not parse [@mirage22 ] as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@guruhb
Copy link
Collaborator Author

guruhb commented Dec 20, 2020

Updated Unit test due to two modification :

  1. Root JSON object should required value (assuming the value of 1234, Root object should have i.e "v" : 1234)
  2. Value should be represented in Integer rather than String. This is due to refactoring done in d3-flamegraph spiermar/d3-flame-graph@0ecd190

@openjdk
Copy link

openjdk bot commented Dec 21, 2020

@guruhb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7000: Update third party library used in flightrecorder.flameview

Co-authored-by: Miro Wengner <miro.wengner@gmail.com>
Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 21, 2020
@guruhb
Copy link
Collaborator Author

guruhb commented Dec 21, 2020

/contributor add Miro Wengner miro.wengner@gmail.com

@openjdk
Copy link

openjdk bot commented Dec 21, 2020

@guruhb
Contributor Miro Wengner <miro.wengner@gmail.com> successfully added.

@mirage22
Copy link
Collaborator

mirage22 commented Dec 22, 2020

seems work fine on my side!

@guruhb
Copy link
Collaborator Author

guruhb commented Dec 22, 2020

/integrate

@openjdk openjdk bot closed this Dec 22, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 22, 2020
@openjdk
Copy link

openjdk bot commented Dec 22, 2020

@guruhb Pushed as commit 2ede603.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@guruhb guruhb deleted the 7000 branch Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants