Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7076: Rules and Analysis code has exceptions during uitests #189

Closed
wants to merge 3 commits into from

Conversation

Gunde
Copy link
Collaborator

@Gunde Gunde commented Jan 6, 2021

Fixes exceptions encountered during uitests due to empty grouping arrays.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7076: Rules and Analysis code has exceptions during uitests

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/189/head:pull/189
$ git checkout pull/189

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 6, 2021

👋 Welcome back hdafgard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 6, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 6, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 10, 2021

@Gunde This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7076: Rules and Analysis code has exceptions during uitests

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • a21771c: 7032: The banner is missing from help page
  • 8d34bbb: 6973: New Method Profiling Page for JMC
  • 88731ed: 7036: Invoke converters/stringify for event fields and return values
  • 319ad86: 7033: Allow overriding the id (name) of the event type
  • eeddd1e: 7073: Exceptions in FlameGraph
  • 44d7dc8: 7078: Update the p2-maven-plugin to 1.5.0
  • a6d85ef: 7062: Update to the Eclipse 2020-12 platform
  • 2ede603: 7000: Update third party library used in flightrecorder.flameview
  • 46a5590: 7052: The link to BellSoft LMC should be updated

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 10, 2021
@thegreystone
Copy link
Member

Don't forget to update the copyrights to 2021, otherwise good!

@Gunde
Copy link
Collaborator Author

Gunde commented Jan 12, 2021

/integrate

@openjdk openjdk bot closed this Jan 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 12, 2021
@openjdk
Copy link

openjdk bot commented Jan 12, 2021

@Gunde Since your change was applied there have been 9 commits pushed to the master branch:

  • a21771c: 7032: The banner is missing from help page
  • 8d34bbb: 6973: New Method Profiling Page for JMC
  • 88731ed: 7036: Invoke converters/stringify for event fields and return values
  • 319ad86: 7033: Allow overriding the id (name) of the event type
  • eeddd1e: 7073: Exceptions in FlameGraph
  • 44d7dc8: 7078: Update the p2-maven-plugin to 1.5.0
  • a6d85ef: 7062: Update to the Eclipse 2020-12 platform
  • 2ede603: 7000: Update third party library used in flightrecorder.flameview
  • 46a5590: 7052: The link to BellSoft LMC should be updated

Your commit was automatically rebased without conflicts.

Pushed as commit 1e7cd87.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants