Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7081: Update Copyright year to 2021, Validate and update license attributes #190

Closed
wants to merge 4 commits into from

Conversation

@guruhb
Copy link
Collaborator

@guruhb guruhb commented Jan 7, 2021

Updated Copyright year to 2021 for below

  1. License show in "About" dialog
  2. Copyright year in License file
  3. Update site landing page
  4. added a helper script which can be used to update copyright year for modified git files.

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7081: Update Copyright year to 2021, Validate and update license attributes

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/190/head:pull/190
$ git checkout pull/190

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 7, 2021

👋 Welcome back ghb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 7, 2021

@guruhb guruhb changed the title 7081: Update Copyright year to 2021 7081: Update Copyright year to 2021, Validate and update license attributes Jan 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@guruhb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7081: Update Copyright year to 2021, Validate and update license attributes

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 549cba0: 7079: Numeric values in automated analysis summary is not resolved
  • 1e7cd87: 7076: Rules and Analysis code has exceptions during uitests
  • a21771c: 7032: The banner is missing from help page
  • 8d34bbb: 6973: New Method Profiling Page for JMC
  • 88731ed: 7036: Invoke converters/stringify for event fields and return values
  • 319ad86: 7033: Allow overriding the id (name) of the event type
  • eeddd1e: 7073: Exceptions in FlameGraph
  • 44d7dc8: 7078: Update the p2-maven-plugin to 1.5.0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 12, 2021
@thegreystone
Copy link
Member

@thegreystone thegreystone commented Jan 12, 2021

Pinged @guruhb about not hardcoding the from year in the copyright updating script - he'll said he'll fix before pushing.

@guruhb
Copy link
Collaborator Author

@guruhb guruhb commented Jan 12, 2021

Pinged @guruhb about not hardcoding the from year in the copyright updating script - he'll said he'll fix before pushing.

Modified the script + also fixed to work with bash and Non Mac terminal.

@guruhb
Copy link
Collaborator Author

@guruhb guruhb commented Jan 12, 2021

/integrate

@openjdk openjdk bot closed this Jan 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@guruhb Since your change was applied there have been 8 commits pushed to the master branch:

  • 549cba0: 7079: Numeric values in automated analysis summary is not resolved
  • 1e7cd87: 7076: Rules and Analysis code has exceptions during uitests
  • a21771c: 7032: The banner is missing from help page
  • 8d34bbb: 6973: New Method Profiling Page for JMC
  • 88731ed: 7036: Invoke converters/stringify for event fields and return values
  • 319ad86: 7033: Allow overriding the id (name) of the event type
  • eeddd1e: 7073: Exceptions in FlameGraph
  • 44d7dc8: 7078: Update the p2-maven-plugin to 1.5.0

Your commit was automatically rebased without conflicts.

Pushed as commit deb32e7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@guruhb guruhb deleted the guruhb:7081 branch Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants