Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7008: Agent should properly support Class and Thread #192

Closed

Conversation

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Jan 10, 2021

Also fixes various issues and tests.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7008: Agent should properly support Class and Thread

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/192/head:pull/192
$ git checkout pull/192

Temporary

Switching computers

Fixing tests

Supporting Thread and Class

Typo

Various fixes, adding tests, bumping to 1.0.0
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 10, 2021

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 10, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 10, 2021

Webrevs

Copy link
Collaborator

@Josh-Matsuoka Josh-Matsuoka left a comment

Looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 13, 2021

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7008: Agent should properly support Class and Thread

Reviewed-by: jmatsuoka, ghb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 0b8055a: 6859: Correction in JMC welcome page
  • ed12346: 4167: "Copy Column Headers" in stack trace view has no effect
  • 21239bc: 6988: Initial implementation of JFR binary format writer
  • 33e684b: 6946: There should be an option to build the agent in the build script
  • 8d6fb1b: 7063: JfrThreadsPageTest (UI-test) fails
  • b6fe7ca: 7002: Too large graphs will freeze JMC
  • deb32e7: 7081: Update Copyright year to 2021, Validate and update license attributes
  • 549cba0: 7079: Numeric values in automated analysis summary is not resolved
  • 1e7cd87: 7076: Rules and Analysis code has exceptions during uitests
  • a21771c: 7032: The banner is missing from help page

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 13, 2021
@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Jan 13, 2021

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Jan 13, 2021

@thegreystone
The number of required reviews for this PR is now set to 2 (with at least 1 of role committers).

@openjdk openjdk bot removed the ready label Jan 13, 2021
guruhb
guruhb approved these changes Jan 18, 2021
Copy link
Collaborator

@guruhb guruhb left a comment

Changes looks good to me ..

Please update Copyright year for below file before integrating
agent/src/main/java/org/openjdk/jmc/agent/Agent.java
agent/src/main/java/org/openjdk/jmc/agent/jfr/JFRTransformDescriptor.java
agent/src/main/java/org/openjdk/jmc/agent/jfr/impl/JFREventClassGenerator.java
agent/src/main/java/org/openjdk/jmc/agent/jfr/impl/JFRMethodAdvisor.java
agent/src/main/java/org/openjdk/jmc/agent/jfrlegacy/impl/JFRLegacyMethodAdvisor.java
agent/src/main/java/org/openjdk/jmc/agent/util/TypeUtils.java
agent/src/test/java/org/openjdk/jmc/agent/converters/test/InstrumentMeConverter.java
agent/src/test/java/org/openjdk/jmc/agent/converters/test/ObjectConverterClass.java
agent/src/test/resources/org/openjdk/jmc/agent/converters/test/jfrprobes_template.xml

@openjdk openjdk bot added the ready label Jan 18, 2021
@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Jan 18, 2021

/integrate

@openjdk openjdk bot closed this Jan 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 18, 2021

@thegreystone Since your change was applied there have been 10 commits pushed to the master branch:

  • 0b8055a: 6859: Correction in JMC welcome page
  • ed12346: 4167: "Copy Column Headers" in stack trace view has no effect
  • 21239bc: 6988: Initial implementation of JFR binary format writer
  • 33e684b: 6946: There should be an option to build the agent in the build script
  • 8d6fb1b: 7063: JfrThreadsPageTest (UI-test) fails
  • b6fe7ca: 7002: Too large graphs will freeze JMC
  • deb32e7: 7081: Update Copyright year to 2021, Validate and update license attributes
  • 549cba0: 7079: Numeric values in automated analysis summary is not resolved
  • 1e7cd87: 7076: Rules and Analysis code has exceptions during uitests
  • a21771c: 7032: The banner is missing from help page

Your commit was automatically rebased without conflicts.

Pushed as commit 2b1af41.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the 7008-support-class-and-thread branch Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants