Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7093: Wrong copyright year #199

Closed

Conversation

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Jan 18, 2021

Missed gurus comment in the last PR.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/199/head:pull/199
$ git checkout pull/199

@thegreystone thegreystone requested a review from guruhb Jan 18, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 18, 2021

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 18, 2021

Webrevs

Copy link
Collaborator

@jiekang jiekang left a comment

Changes look fine to me.

guruhb
guruhb approved these changes Jan 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 19, 2021

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7093: Wrong copyright year

Reviewed-by: jkang, ghb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 19, 2021
@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Jan 19, 2021

/integrate

@openjdk openjdk bot closed this Jan 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 19, 2021

@thegreystone Pushed as commit d4cfbd2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the 7093-wrong-copyright-year branch Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants