Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7116: Update version to 8.1.0 in master #206

Closed
wants to merge 6 commits into from

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Jan 22, 2021

Also cleaning up the maven versioning.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7116: Update version to 8.1.0 in master

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/206/head:pull/206
$ git checkout pull/206

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 22, 2021

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 22, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 22, 2021

Webrevs

@jiekang
Copy link
Collaborator

jiekang commented Jan 22, 2021

Hello! Changes look good; I have two requests below:

Can application/uitests/pom.xml use project.version instead of defining its own jmc.version for its dependencies?

Regarding the deployed/installed jmc-core, the maven guide [1] states that the flatten-maven-plugin must be used to deal with this (with example). I would like to request this actually be done for jmc too as there is a project that uses jmc maven dependencies from the m2 repo. Without it, the project would break similar to the jmc & jmc-core relationship.

[1]
https://maven.apache.org/maven-ci-friendly.html#install-deploy

Copy link
Contributor

@guruhb guruhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good to me.

@thegreystone thegreystone removed the request for review from jiekang January 23, 2021 15:12
@thegreystone thegreystone changed the title 7116: Updating to 8.1.0 7116: Update version to 8.1.0 in master Jan 23, 2021
@openjdk
Copy link

openjdk bot commented Jan 23, 2021

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7116: Update version to 8.1.0 in master

Reviewed-by: ghb, jkang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • ef0d457: 7117: JMC with Eclipse 2020-06 fails to launch in simplified Chinese language

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 23, 2021
@thegreystone thegreystone requested a review from jiekang January 23, 2021 15:13
core/pom.xml Show resolved Hide resolved
@thegreystone
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Jan 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 26, 2021
@openjdk
Copy link

openjdk bot commented Jan 26, 2021

@thegreystone Since your change was applied there has been 1 commit pushed to the master branch:

  • ef0d457: 7117: JMC with Eclipse 2020-06 fails to launch in simplified Chinese language

Your commit was automatically rebased without conflicts.

Pushed as commit 2bcb03e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the 7116-update-version branch January 26, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants