Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7117: JMC with Eclipse 2020-06 fails to launch in simplified Chinese language #207

Closed
wants to merge 1 commit into from

Conversation

guruhb
Copy link
Contributor

@guruhb guruhb commented Jan 22, 2021

Jmc fails to launch with Eclipse 2020-06 SDK in "zh_CN" (simplified Chinese Language).
Note: This defect is only for Eclipse 2020-06 and not with Eclipse 2020-09 or later .

Solution : Using the latest version of babel which has the fix as part of https://bugs.eclipse.org/bugs/show_bug.cgi?id=565976 (Fixed in https://bugs.eclipse.org/bugs/show_bug.cgi?id=565380 )

 


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7117: JMC with Eclipse 2020-06 fails to launch in simplified Chinese language

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/207/head:pull/207
$ git checkout pull/207

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 22, 2021

👋 Welcome back ghb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 22, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 22, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 22, 2021

@guruhb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7117: JMC with Eclipse 2020-06 fails to launch in simplified Chinese language

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 22, 2021
@guruhb
Copy link
Contributor Author

guruhb commented Jan 23, 2021

/integrate

@openjdk openjdk bot closed this Jan 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 23, 2021
@openjdk
Copy link

openjdk bot commented Jan 23, 2021

@guruhb Pushed as commit ef0d457.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@guruhb guruhb deleted the 7117 branch June 7, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants