Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7088: Show concurrent option showing lesser number of records. #208

Closed
wants to merge 3 commits into from

Conversation

@Gunde
Copy link
Collaborator

@Gunde Gunde commented Feb 3, 2021

Due to how StreamBackedItemCollections differ from EventCollections we can't rely on the assumption made that disjoint events are sorted in each IItemIterable. And since the classes aren't visible from RulesToolkit we have to look at the class name like this.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7088: Show concurrent option showing lesser number of records.

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/208/head:pull/208
$ git checkout pull/208

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 3, 2021

👋 Welcome back hdafgard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 3, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Feb 4, 2021

@Gunde This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7088: Show concurrent option showing lesser number of records.

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7b1ae3e: 7039: Timestamp granularity too coarse

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 4, 2021
@thegreystone
Copy link
Member

@thegreystone thegreystone commented Feb 4, 2021

@Gunde, please /integrate so that @guruhb can cherry pick this one for 8.

@Gunde
Copy link
Collaborator Author

@Gunde Gunde commented Feb 4, 2021

/integrate

@openjdk openjdk bot closed this Feb 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 4, 2021

@Gunde Since your change was applied there has been 1 commit pushed to the master branch:

  • 7b1ae3e: 7039: Timestamp granularity too coarse

Your commit was automatically rebased without conflicts.

Pushed as commit bd35f0b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Gunde Gunde deleted the JMC-7088 branch Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants