Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6753: JMC Help Documentation requires corrections #212

Closed
wants to merge 1 commit into from

Conversation

@Suchitainf
Copy link
Collaborator

@Suchitainf Suchitainf commented Feb 5, 2021

This PR updates the old instructions of starting JMC when it was bundled as part of jdk.

Please review the change and let me know if there are any changes required.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6753: JMC Help Documentation requires corrections

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/212/head:pull/212
$ git checkout pull/212

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 5, 2021

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 5, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Feb 8, 2021

@Suchitainf This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6753: JMC Help Documentation requires corrections

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 77605de: 7133: Update the build script help to include the installCore option
  • 9381a9a: 6907: Upgrade Jacoco to 0.8.6
  • 3645eb1: 7130: JfrThreadsPageTest (UI-test) fails (part 2)
  • 80f7c2d: 7121: Unhandled exception while working with Thread Graphs
  • a248e5c: 7120: Charts in custom pages are not auto refreshed
  • bd35f0b: 7088: Show concurrent option showing lesser number of records.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 8, 2021
@Suchitainf
Copy link
Collaborator Author

@Suchitainf Suchitainf commented Feb 8, 2021

/integrate

@openjdk openjdk bot closed this Feb 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 8, 2021

@Suchitainf Since your change was applied there have been 7 commits pushed to the master branch:

  • 369c150: 7040: Event list is not updated and Stack trace stale upon Set as Focused Selection
  • 77605de: 7133: Update the build script help to include the installCore option
  • 9381a9a: 6907: Upgrade Jacoco to 0.8.6
  • 3645eb1: 7130: JfrThreadsPageTest (UI-test) fails (part 2)
  • 80f7c2d: 7121: Unhandled exception while working with Thread Graphs
  • a248e5c: 7120: Charts in custom pages are not auto refreshed
  • bd35f0b: 7088: Show concurrent option showing lesser number of records.

Your commit was automatically rebased without conflicts.

Pushed as commit 733aacf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants