Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7205: Correct URL for Oracle's JMC production binaries #216

Closed
wants to merge 2 commits into from

Conversation

aureliogrb
Copy link
Contributor

@aureliogrb aureliogrb commented Feb 9, 2021


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7205: Correct URL for Oracle's JMC production binaries

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/216/head:pull/216
$ git checkout pull/216

To update a local copy of the PR:
$ git checkout pull/216
$ git pull https://git.openjdk.java.net/jmc pull/216/head

@bridgekeeper bridgekeeper bot added the oca label Feb 9, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2021

Hi @aureliogrb, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user aureliogrb" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@thegreystone
Copy link
Member

Hey! Hi Aurelio! :) You gotta enter a message only containing /covered.

@thegreystone
Copy link
Member

thegreystone commented Feb 10, 2021

Also, there needs to be a matching JBS bug, and the PR message must be changed to <BUGID>: <issue summary>. See other already closed PRs for examples.

@thegreystone thegreystone self-requested a review February 10, 2021 00:48
README.md Outdated
@@ -33,7 +33,7 @@ Binary distributions of JDK Mission Control are provided by different downstream
* Integrated (in-app) update site
* Eclipse update site

[http://jdk.java.net/jmc](http://jdk.java.net/jmc)
[https://www.oracle.com/java/technologies/javase/products-jmc7-downloads.html](https://www.oracle.com/java/technologies/javase/products-jmc7-downloads.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want the URL to be the jmc7 downloads? Do you have a top level download URL that will point to the latest always?

@bridgekeeper bridgekeeper bot removed the oca label Feb 10, 2021
@thegreystone
Copy link
Member

Ping @aureliogrb.

@thegreystone
Copy link
Member

Ping again @aureliogrb. This has been lingering for quite some time now. Can I help?

@thegreystone thegreystone changed the title Corrected URL for Oracle's JMC production binaries 7205: Corrected URL for Oracle's JMC production binaries Mar 23, 2021
@thegreystone thegreystone changed the title 7205: Corrected URL for Oracle's JMC production binaries 7205: Correct URL for Oracle's JMC production binaries Mar 23, 2021
@openjdk openjdk bot added the rfr label Mar 23, 2021
@thegreystone
Copy link
Member

Added an issue in Jira, and updated the PR name to the required format. This one is now ready to go.

@openjdk
Copy link

openjdk bot commented Mar 23, 2021

@aureliogrb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7205: Correct URL for Oracle's JMC production binaries

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 6149b48: 6890: defineEventProbes should throw exception on malformed probe definitions
  • acbc1e6: 7158: [JFR Writer] Improve single-value types handling
  • 2111820: 7156: [JFR Writer] Allow providing extra recording settings
  • 20d8777: 7155: [JFR Writer] Complete the annotation handling code
  • e97d985: 7154: [JFR Writer] Improve lazy evaluation of the type defining block
  • c1937f1: 7139: Prepare new and noteworthy for JMC 8.0.0
  • 0c7ae2a: 6936: Parser should track statistics during parsing
  • e52a361: 7136: Restrict local management agent for own process
  • 3a19fb5: 7131: Uitests failing on Windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 23, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 23, 2021

Webrevs

@aureliogrb
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor label Mar 25, 2021
@openjdk
Copy link

openjdk bot commented Mar 25, 2021

@aureliogrb
Your change (at version 9b1c83d) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 25, 2021

@thegreystone @aureliogrb Since your change was applied there have been 9 commits pushed to the master branch:

  • 6149b48: 6890: defineEventProbes should throw exception on malformed probe definitions
  • acbc1e6: 7158: [JFR Writer] Improve single-value types handling
  • 2111820: 7156: [JFR Writer] Allow providing extra recording settings
  • 20d8777: 7155: [JFR Writer] Complete the annotation handling code
  • e97d985: 7154: [JFR Writer] Improve lazy evaluation of the type defining block
  • c1937f1: 7139: Prepare new and noteworthy for JMC 8.0.0
  • 0c7ae2a: 6936: Parser should track statistics during parsing
  • e52a361: 7136: Restrict local management agent for own process
  • 3a19fb5: 7131: Uitests failing on Windows

Your commit was automatically rebased without conflicts.

Pushed as commit 1c008c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants