-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7205: Correct URL for Oracle's JMC production binaries #216
Conversation
Hi @aureliogrb, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user aureliogrb" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
Hey! Hi Aurelio! :) You gotta enter a message only containing /covered. |
Also, there needs to be a matching JBS bug, and the PR message must be changed to <BUGID>: <issue summary>. See other already closed PRs for examples. |
README.md
Outdated
@@ -33,7 +33,7 @@ Binary distributions of JDK Mission Control are provided by different downstream | |||
* Integrated (in-app) update site | |||
* Eclipse update site | |||
|
|||
[http://jdk.java.net/jmc](http://jdk.java.net/jmc) | |||
[https://www.oracle.com/java/technologies/javase/products-jmc7-downloads.html](https://www.oracle.com/java/technologies/javase/products-jmc7-downloads.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you want the URL to be the jmc7 downloads? Do you have a top level download URL that will point to the latest always?
Ping @aureliogrb. |
Ping again @aureliogrb. This has been lingering for quite some time now. Can I help? |
Added an issue in Jira, and updated the PR name to the required format. This one is now ready to go. |
@aureliogrb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@aureliogrb |
/sponsor |
@thegreystone @aureliogrb Since your change was applied there have been 9 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 1c008c3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Progress
Issue
Reviewers
Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/216/head:pull/216
$ git checkout pull/216
To update a local copy of the PR:
$ git checkout pull/216
$ git pull https://git.openjdk.java.net/jmc pull/216/head