-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6936: Parser should track statistics during parsing #219
Conversation
Add new IParserStats interface implemented by EventCollection. That way, IItemCollection is not touched, but you need to cast the instance to IParserStats. Support of old (v0.x) JFR format. During parsing, we collect number of events per type, the size, number of chunks and version of the file. We also track for version 1.x/2.x the number of skipped events. RecordPrinter tool class is modified to support a summary verbosity mode and -summary option to print statistics per event type.
👋 Welcome back jpbempel! A progress list of the required criteria for merging this PR into |
Webrevs
|
...dk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/EventArrays.java
Show resolved
Hide resolved
@@ -39,7 +39,7 @@ | |||
* Contains type IDs for events that are produced by JDK 7 and 8. | |||
*/ | |||
@SuppressWarnings({"nls", "unused"}) | |||
final class JdkTypeIDsPreJdk11 { | |||
public final class JdkTypeIDsPreJdk11 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made public to be able to use it from here:
Line 100 in 9f96658
String typeId = JdkTypeIDsPreJdk11.translate(id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we make that class public, we might as well rename it. Since the JDK 8 backport, it really is Oracle type IDs - so perhaps OracleJdkTypeIDsPre11?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Do we need the number of events per type? Isn't that the same as a count aggregate with a type filter? |
Sure it's the same (or should be 😁 ) but at least you have this information close to the other ones to interpret them |
@jpbempel This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
@thegreystone @jpbempel Pushed as commit 0c7ae2a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Add new
IParserStats
interface implemented byEventCollection
.That way,
IItemCollection
is not touched, but you need to cast theinstance to
IParserStats
.Support of old (v0.x) JFR format.
During parsing, we collect number of events per type, the size, number
of chunks and version of the file.
We also track for version 1.x/2.x the number of skipped events.
RecordingPrinter
tool class is modified to support a summary verbosity modeand
-summary
option to print statistics per event type.Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jmc pull/219/head:pull/219
$ git checkout pull/219