Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7139: Prepare new and noteworthy for JMC 8.0.0 #220

Closed

Conversation

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Feb 26, 2021

There is a launcher included to build from within Eclipse. Import the project into Eclipse and run the launcher. Open the generated html page in a browser.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7139: Prepare new and noteworthy for JMC 8.0.0

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/220/head:pull/220
$ git checkout pull/220

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 26, 2021

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 26, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 26, 2021

Webrevs

@thegreystone thegreystone requested a review from guruhb Mar 1, 2021
Copy link
Collaborator

@guruhb guruhb left a comment

Looks good to me

guruhb
guruhb approved these changes Mar 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 12, 2021

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7139: Prepare new and noteworthy for JMC 8.0.0

Reviewed-by: ghb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 0c7ae2a: 6936: Parser should track statistics during parsing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 12, 2021
@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Mar 12, 2021

/integrate

@openjdk openjdk bot closed this Mar 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 12, 2021

@thegreystone Since your change was applied there has been 1 commit pushed to the master branch:

  • 0c7ae2a: 6936: Parser should track statistics during parsing

Your commit was automatically rebased without conflicts.

Pushed as commit c1937f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the 7139-new-and-noteworthy branch Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants