-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JMC-7155: [JFR Writer] Complete the annotation handling code #222
Conversation
👋 Welcome back jbachorik! A progress list of the required criteria for merging this PR into |
Webrevs
|
@AlexVanGogen can you, as an active user of this API, take a look at this, plz? |
...lightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/TypedFieldImpl.java
Show resolved
Hide resolved
@@ -0,0 +1,32 @@ | |||
package org.openjdk.jmc.flightrecorder.writer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright header (Oracle + DD).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😿 I really need to set up some templates. Always forgetting about this :(
@@ -0,0 +1,67 @@ | |||
package org.openjdk.jmc.flightrecorder.writer.api; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright header.
@@ -0,0 +1,37 @@ | |||
package org.openjdk.jmc.flightrecorder.writer.api; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright header.
@jbachorik This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@jbachorik |
/sponsor |
@thegreystone @jbachorik Since your change was applied there have been 3 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 20d8777. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
JMC-7155: [JFR Writer] Complete the annotation handling code
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jmc pull/222/head:pull/222
$ git checkout pull/222