Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMC-7155: [JFR Writer] Complete the annotation handling code #222

Closed
wants to merge 2 commits into from

Conversation

jbachorik
Copy link
Collaborator

@jbachorik jbachorik commented Mar 1, 2021

JMC-7155: [JFR Writer] Complete the annotation handling code


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7155: [JFR Writer] Complete the annotation handling code

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/222/head:pull/222
$ git checkout pull/222

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 1, 2021

👋 Welcome back jbachorik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 1, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 1, 2021

Webrevs

@jbachorik
Copy link
Collaborator Author

@AlexVanGogen can you, as an active user of this API, take a look at this, plz?

@@ -0,0 +1,32 @@
package org.openjdk.jmc.flightrecorder.writer;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright header (Oracle + DD).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😿 I really need to set up some templates. Always forgetting about this :(

@@ -0,0 +1,67 @@
package org.openjdk.jmc.flightrecorder.writer.api;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright header.

@@ -0,0 +1,37 @@
package org.openjdk.jmc.flightrecorder.writer.api;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright header.

@openjdk
Copy link

openjdk bot commented Mar 15, 2021

@jbachorik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7155: [JFR Writer] Complete the annotation handling code

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • e97d985: 7154: [JFR Writer] Improve lazy evaluation of the type defining block
  • c1937f1: 7139: Prepare new and noteworthy for JMC 8.0.0
  • 0c7ae2a: 6936: Parser should track statistics during parsing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 15, 2021
@jbachorik
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot added the sponsor label Mar 16, 2021
@openjdk
Copy link

openjdk bot commented Mar 16, 2021

@jbachorik
Your change (at version a789678) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 16, 2021

@thegreystone @jbachorik Since your change was applied there have been 3 commits pushed to the master branch:

  • e97d985: 7154: [JFR Writer] Improve lazy evaluation of the type defining block
  • c1937f1: 7139: Prepare new and noteworthy for JMC 8.0.0
  • 0c7ae2a: 6936: Parser should track statistics during parsing

Your commit was automatically rebased without conflicts.

Pushed as commit 20d8777.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants