-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6890: defineEventProbes should throw exception on malformed probe definitions #227
Conversation
👋 Welcome back jmatsuoka! A progress list of the required criteria for merging this PR into |
Webrevs
|
Don't forget to update the copyright years. |
agent/src/main/java/org/openjdk/jmc/agent/TransformRegistry.java
Outdated
Show resolved
Hide resolved
@Josh-Matsuoka This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@Josh-Matsuoka Since your change was applied there have been 5 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 6149b48. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR addresses JMC-6890 (defineEventProbes should throw exception on malformed probe definitions) [1]. Previously the exception would be swallowed by DefaultTransformRegistry when the XML failed validation, and would simply return null. With this change the exception is rethrown and can be handled accordingly by the AgentController, which rethrows it, and the user. I've added a test for the AgentController and updated the test for DefaultTransformRegistry accordingly.
[1] https://bugs.openjdk.java.net/browse/JMC-6890
Progress
Issue
Reviewers
Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/227/head:pull/227
$ git checkout pull/227
To update a local copy of the PR:
$ git checkout pull/227
$ git pull https://git.openjdk.java.net/jmc pull/227/head