6890: defineEventProbes should throw exception on malformed probe definitions

[Josh-Matsuoka]

This PR addresses JMC-6890 (defineEventProbes should throw exception on malformed probe definitions) [1]. Previously the exception would be swallowed by DefaultTransformRegistry when the XML failed validation, and would simply return null. With this change the exception is rethrown and can be handled accordingly by the AgentController, which rethrows it, and the user. I've added a test for the AgentController and updated the test for DefaultTransformRegistry accordingly.

[1] https://bugs.openjdk.java.net/browse/JMC-6890

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JMC-6890: defineEventProbes should throw exception on malformed probe definitions

Reviewers

• Marcus Hirt (@thegreystone - Reviewer)

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/227/head:pull/227
$ git checkout pull/227

To update a local copy of the PR:
$ git checkout pull/227
$ git pull https://git.openjdk.java.net/jmc pull/227/head

[bridgekeeper]

👋 Welcome back jmatsuoka! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (5c6c695)
• 00: Full (b563856)

[thegreystone]

Don't forget to update the copyright years.

[openjdk]

@Josh-Matsuoka This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6890: defineEventProbes should throw exception on malformed probe definitions

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• acbc1e6: 7158: [JFR Writer] Improve single-value types handling
• 2111820: 7156: [JFR Writer] Allow providing extra recording settings
• 20d8777: 7155: [JFR Writer] Complete the annotation handling code
• e97d985: 7154: [JFR Writer] Improve lazy evaluation of the type defining block
• c1937f1: 7139: Prepare new and noteworthy for JMC 8.0.0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[Josh-Matsuoka]

/integrate

[openjdk]

@Josh-Matsuoka Since your change was applied there have been 5 commits pushed to the master branch:

• acbc1e6: 7158: [JFR Writer] Improve single-value types handling
• 2111820: 7156: [JFR Writer] Allow providing extra recording settings
• 20d8777: 7155: [JFR Writer] Complete the annotation handling code
• e97d985: 7154: [JFR Writer] Improve lazy evaluation of the type defining block
• c1937f1: 7139: Prepare new and noteworthy for JMC 8.0.0

Your commit was automatically rebased without conflicts.

Pushed as commit 6149b48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.