7031: Build a constant pool explorer page

[jpbempel]

Add under Recording a new Page for ConstantPools
Help to visualize what's inside constant pools part of a JFR recording

Draft

• Icon is copy/paste from recording. If you have idea about how to replace it...
• I have limited the tables to the search toolbar, visible by default
• a hidden count column for constant values helps you find out when you duplicates constant (for OldObjectSample event issue) should not be useful otherwise

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JMC-7031: Build a constant pool explorer page

Reviewers

• Marcus Hirt (@thegreystone - Reviewer) ⚠️ Review applies to a3a17f9
• Henrik Dafgård (@Gunde - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/228/head:pull/228
$ git checkout pull/228

Update a local copy of the PR:
$ git checkout pull/228
$ git pull https://git.openjdk.java.net/jmc pull/228/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 228

View PR using the GUI difftool:
$ git pr show -t 228

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/228.diff

[bridgekeeper]

👋 Welcome back jpbempel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (7069d49f)
• 00: Full (a3a17f9)

[thegreystone]

/reviewers 2

[openjdk]

@thegreystone
The number of required reviews for this PR is now set to 2 (with at least 1 of role committers).

[Gunde]

Looks good except for the state handling for the sash.

[Gunde]

This saves the state of the SashForm, but that state isn't loaded in the IPageUI constructor, so the value used will only be the default for a SashForm.

E.g. PersistableSashForm.loadState(sash, state.getChild(SASH));

[jpbempel]

done

[openjdk]

@jpbempel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7031: Build a constant pool explorer page

Reviewed-by: hirt, hdafgard

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• a2f6b15: 7046: Update to the 2021-03 platform
• f1a63ec: 7162: Stop using the chromium library based browser component
• 2e242ec: 7191: The release notes tool should be using JDK 8
• 1c008c3: 7205: Correct URL for Oracle's JMC production binaries
• 6149b48: 6890: defineEventProbes should throw exception on malformed probe definitions
• acbc1e6: 7158: [JFR Writer] Improve single-value types handling
• 2111820: 7156: [JFR Writer] Allow providing extra recording settings
• 20d8777: 7155: [JFR Writer] Complete the annotation handling code
• e97d985: 7154: [JFR Writer] Improve lazy evaluation of the type defining block
• c1937f1: 7139: Prepare new and noteworthy for JMC 8.0.0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone, @Gunde) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jpbempel]

/integrate

[openjdk]

@jpbempel
Your change (at version 7069d49) is now ready to be sponsored by a Committer.

[thegreystone]

/sponsor

[openjdk]

@thegreystone @jpbempel Since your change was applied there have been 11 commits pushed to the master branch:

• b46be35: 7225: Add workflow badge to the readme
• a2f6b15: 7046: Update to the 2021-03 platform
• f1a63ec: 7162: Stop using the chromium library based browser component
• 2e242ec: 7191: The release notes tool should be using JDK 8
• 1c008c3: 7205: Correct URL for Oracle's JMC production binaries
• 6149b48: 6890: defineEventProbes should throw exception on malformed probe definitions
• acbc1e6: 7158: [JFR Writer] Improve single-value types handling
• 2111820: 7156: [JFR Writer] Allow providing extra recording settings
• 20d8777: 7155: [JFR Writer] Complete the annotation handling code
• e97d985: 7154: [JFR Writer] Improve lazy evaluation of the type defining block
• ... and 1 more: https://git.openjdk.java.net/jmc/compare/0c7ae2a0f6423d76f74d9dba53fe5d693a3a7c0c...master

Your commit was automatically rebased without conflicts.

Pushed as commit f25df12.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.