Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7191: The release notes tool should be using JDK 8 #229

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Mar 17, 2021

Right now the launcher will not work out of the box.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7191: The release notes tool should be using JDK 8

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/229/head:pull/229
$ git checkout pull/229

Update a local copy of the PR:
$ git checkout pull/229
$ git pull https://git.openjdk.java.net/jmc pull/229/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 229

View PR using the GUI difftool:
$ git pr show -t 229

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/229.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 17, 2021

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 17, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 17, 2021

Webrevs

@thegreystone thegreystone requested review from Gunde and guruhb March 19, 2021 15:44
@openjdk
Copy link

openjdk bot commented Mar 30, 2021

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7191: The release notes tool should be using JDK 8

Reviewed-by: hdafgard

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 1c008c3: 7205: Correct URL for Oracle's JMC production binaries
  • 6149b48: 6890: defineEventProbes should throw exception on malformed probe definitions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 30, 2021
@thegreystone
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Mar 31, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 31, 2021
@openjdk
Copy link

openjdk bot commented Mar 31, 2021

@thegreystone Since your change was applied there have been 2 commits pushed to the master branch:

  • 1c008c3: 7205: Correct URL for Oracle's JMC production binaries
  • 6149b48: 6890: defineEventProbes should throw exception on malformed probe definitions

Your commit was automatically rebased without conflicts.

Pushed as commit 2e242ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the 7191-release-notes-launcher-fix branch October 16, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants