Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7195: GC confguration with GC Flags #230

Closed
wants to merge 10 commits into from
Closed

Conversation

@bric3
Copy link
Contributor

@bric3 bric3 commented Mar 18, 2021

This pull request proposes to display related garbage collector flags.

Motivation

When turning the GC flag knobs, it is useful to be able to quickly see
the GC configuration, however the GC configuration page only show 3
events, if one wants to have a look at flags he has to either check
the command line or inspect the JVM internal page to find relevant
GC flags. Therefore having these flags right there is useful to get
a quick picture of the current configuration.

Current limitations

  1. At this time the selected flags depends on the GC algorithm which is
    derived from the name of the old collector name. This is simple,
    however it prevents to identify EpsilonGC because whose old
    collector name is SerialOld, which is the same as SerialGC.

  2. There are some global flags in gc/shared/gc_globals.hpp that
    I didn't include as I didn't use most of them. I'm not sure these
    flags are seen much in the wild.

Remarks

As mentionned above the use of the OldCollector name may not be the
best choice, I would like to refactor this part to use the Use*GC
flags instead. I am a bit unsure at this time how to use the
existing API.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7195: GC confguration with GC Flags

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/230/head:pull/230
$ git checkout pull/230

Update a local copy of the PR:
$ git checkout pull/230
$ git pull https://git.openjdk.java.net/jmc pull/230/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 230

View PR using the GUI difftool:
$ git pr show -t 230

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/230.diff

@bridgekeeper bridgekeeper bot added the oca label Mar 18, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 18, 2021

Hi @bric3, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user bric3" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@bric3
Copy link
Contributor Author

@bric3 bric3 commented Mar 18, 2021

/signed

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 18, 2021

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@thegreystone thegreystone changed the title GC confguration with GC Flags 7195: GC confguration with GC Flags Mar 18, 2021
@thegreystone
Copy link
Member

@thegreystone thegreystone commented Mar 19, 2021

Don't forget to update the copyright header years. If you need to add a year to make a year range, simply add a comma and the new year, e.g. like so:

Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.

@bric3 bric3 marked this pull request as ready for review Apr 2, 2021
@openjdk openjdk bot added the rfr label Apr 2, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 2, 2021

Webrevs

@thegreystone
Copy link
Member

@thegreystone thegreystone commented May 12, 2021

Sorry for the delay @bric3, and thank you your contribution! :)

@openjdk
Copy link

@openjdk openjdk bot commented May 12, 2021

@bric3 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7195: GC confguration with GC Flags

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label May 12, 2021
@bric3
Copy link
Contributor Author

@bric3 bric3 commented May 18, 2021

/integrate

@openjdk openjdk bot added the sponsor label May 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@bric3
Your change (at version ff0c91f) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

@thegreystone thegreystone commented May 18, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@thegreystone @bric3 Since your change was applied there have been 18 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 39643ce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bric3 bric3 deleted the gx-conf-with-flags branch May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants