7194 : No local JVMs found message could be more helpful

[docwarems]

The message refers to the FAQ to question
"Q: I cannot see any locally running JVMs in the JVM browser!"
Suggestion for new answer
A3: Are you running a JDK <11? You must specify a JDK >=11 either via PATH of by adding "-vm" parameter in jmc.ini (before -vmargs parameter; value is path to JDK bin folder)

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JMC-7194: No local JVMs found message could be more helpful

Reviewers

• Marcus Hirt (@thegreystone - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/232/head:pull/232
$ git checkout pull/232

Update a local copy of the PR:
$ git checkout pull/232
$ git pull https://git.openjdk.java.net/jmc pull/232/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 232

View PR using the GUI difftool:
$ git pr show -t 232

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/232.diff

[bridgekeeper]

Hi @docwarems, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user docwarems" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[docwarems]

/signed

[bridgekeeper]

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[thegreystone]

Hi there!

There is a suggestion to update the FAQ (https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.docs/html/GUID-3EC7E6C3-6A64-4659-B99E-CA675A9F6E0A.htm), there is however no update to that html file present in the PR.

[docwarems]

There is a suggestion to update the FAQ

OK, but the content of ths repo file is different from the FAQs content I found by Google, to which my PR description refers.

https://wiki.openjdk.java.net/display/jmc/JMC+FAQ
https://community.oracle.com/tech/developers/discussion/2579717/jmc-frequently-asked-questions

[thegreystone]

Feel free to update the JMC-included documentation if you feel it improves it. :) The project itself mostly concerns itself with the included documentation, not the Oracle-hosted FAQ.

[docwarems]

OK, IMO we have this situation:

https://wiki.openjdk.java.net/display/jmc/JMC+FAQ (last updated 02/2020) is the location for publishing the FAQ currently and in the future. It's a Confluence system, and there's no way to sync this with a Git document, because Confluence has it's own versioning.
That means the purpose of the repo FAQ (last update 01/2019) could be not more than for saving the raw content (the HTML format is only used for better reading, otherwise it could be even plain text).

Is my view correct?

To me the published FAQ looks much more useful than the repo FAQ. If you ask me, I would replace the repo with the content from the published FAQ, and add the answer from this PR.

At least we have the content of both in sync then.

[thegreystone]

Does this render OK in the help browser?

1. Start JMC.
2. Go to Help | JDK Mission Control Help.
3. Click Frequently Asked Questions (at the bottom of the TOC).

[docwarems]

Does this render OK in the help browser?

Probably not ;-)

But from my previous comments it could have become obviuos that I wasn't aware of the repo FAQ shown elsewhere. Now that I know that it's parts of the included help, I reverted the commit and added just my new answer.

How will we get rid of the extra commits? Have I to re-push the branch again or is there a squash functionality when the PR will be merged. Sorry, I need help here because it's my first contribution to a GitHub project.

[Gunde]

How will we get rid of the extra commits? Have I to re-push the branch again or is there a squash functionality when the PR will be merged. Sorry, I need help here because it's my first contribution to a GitHub project.

When the PR is integrated all commits will be squashed, so you don't really need to do anything particular here.

[mlbridge]

Webrevs

• 02: Full - Incremental (5fd8944d)
• 01: Full - Incremental (5014130b)
• 00: Full (c3eb33a7)

[thegreystone]

As Henrik said - it's all part of the Skara workflow. It will all automatically be squashed into one neat commit in the end. :)

[openjdk]

⚠️ @docwarems the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JMC-7194_local-jvms-not-found
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@docwarems This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7194: No local JVMs found message could be more helpful

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• f25df12: 7031: Build a constant pool explorer page
• b46be35: 7225: Add workflow badge to the readme
• a2f6b15: 7046: Update to the 2021-03 platform
• f1a63ec: 7162: Stop using the chromium library based browser component
• 2e242ec: 7191: The release notes tool should be using JDK 8
• 1c008c3: 7205: Correct URL for Oracle's JMC production binaries
• 6149b48: 6890: defineEventProbes should throw exception on malformed probe definitions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[thegreystone]

Hi @docwarems! Please read the comments above from the bot. It contains instruction on how to proceed with integrating the PR. Let me know if you need any help!

[docwarems]

I have problems fixing the user name for my commit as described by the bot.
The command gives me this error with my Git client:
fatal: Option -m cannot be combined with -c/-C/-F.

If I omit the -m option it gives me the error
fatal: could not lookup commit user.name=Michael Sdkamp

This is my user name as obtained from "git config --list". As you can see it has an escaped german character. I also tried without success with the unescaped name and with umlaut character replaced by ASCII.
What can I do?

[thegreystone]

Don’t worry too much then. If you are happy with how your name looks in the commits, then simply write /integrate in a comment.

[docwarems]

/integrate

[openjdk]

@docwarems
Your change (at version 5fd8944) is now ready to be sponsored by a Committer.

[thegreystone]

/sponsor

[openjdk]

@thegreystone @docwarems Since your change was applied there have been 7 commits pushed to the master branch:

• f25df12: 7031: Build a constant pool explorer page
• b46be35: 7225: Add workflow badge to the readme
• a2f6b15: 7046: Update to the 2021-03 platform
• f1a63ec: 7162: Stop using the chromium library based browser component
• 2e242ec: 7191: The release notes tool should be using JDK 8
• 1c008c3: 7205: Correct URL for Oracle's JMC production binaries
• 6149b48: 6890: defineEventProbes should throw exception on malformed probe definitions

Your commit was automatically rebased without conflicts.

Pushed as commit 84fc937.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.