Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7046: Update to the 2021-03 platform #235

Closed
wants to merge 3 commits into from

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Apr 2, 2021

Also updating to latest babel for the platform versions that are available in 0.18.3.

Depending on if #234 gets in before or after this one, either this one will need to be updated to remove the chromium entry, or #234 will need to be updated to do it.

(Is it just me, or does JMC start really fast on 4.19? :) )


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7046: Update to the 2021-03 platform

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/235/head:pull/235
$ git checkout pull/235

Update a local copy of the PR:
$ git checkout pull/235
$ git pull https://git.openjdk.java.net/jmc pull/235/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 235

View PR using the GUI difftool:
$ git pr show -t 235

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/235.diff

@thegreystone thegreystone requested a review from guruhb April 2, 2021 00:06
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 2, 2021

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 2, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 2, 2021

Webrevs

Copy link
Contributor

@guruhb guruhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled on Ubuntu, Mac and Windows did some basic sanity test. Looks good to me.

@openjdk
Copy link

openjdk bot commented Apr 2, 2021

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7046: Update to the 2021-03 platform

Reviewed-by: ghb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 2, 2021
@thegreystone thegreystone requested a review from guruhb April 2, 2021 11:17
@thegreystone
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Apr 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 3, 2021
@openjdk
Copy link

openjdk bot commented Apr 3, 2021

@thegreystone Pushed as commit a2f6b15.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the 7046-update-2021-03 branch July 26, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants