Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7236: Adding project specific settings to ignore forbidden references #236

Conversation

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Apr 8, 2021

Since JBS is down for maintenance, I'll add an issue once it's up and happy again.

Update: added issue.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7236: Adding project specific settings to ignore forbidden references

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/236/head:pull/236
$ git checkout pull/236

Update a local copy of the PR:
$ git checkout pull/236
$ git pull https://git.openjdk.java.net/jmc pull/236/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 236

View PR using the GUI difftool:
$ git pr show -t 236

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/236.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 8, 2021

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@thegreystone thegreystone changed the title Adding project specific settings to ignore forbidden references 7236: Adding project specific settings to ignore forbidden references Apr 9, 2021
@openjdk openjdk bot added the rfr label Apr 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 9, 2021

Webrevs

@thegreystone thegreystone requested review from Gunde and guruhb Apr 9, 2021
bric3
bric3 approved these changes May 17, 2021
Gunde
Gunde approved these changes May 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7236: Adding project specific settings to ignore forbidden references

Reviewed-by: hdafgard

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 9852c99: 7256: Use .jcheck/conf property to control version
  • af9df26: 7201: JdkAttributes.OS_SWITCH_RATE does not work consistently across JFRs from different JDK versions.
  • d708be3: 7164: Add support for hidden classes
  • 8653337: 7241: Adjust main pom.xml to more align for 3th party builds
  • 30223c7: 7124: Support the new JDK 16 allocation profiling event
  • 917a95c: 7246: ClassCastException when opening heap dump
  • 7732a7c: 7105: Unable to open graph-view if JMC is booted with JDK 8
  • 033cc93: 6939: Time range indicator isn't updated when setting the time range
  • 84fc937: 7194: No local JVMs found message could be more helpful

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 17, 2021
@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented May 17, 2021

/integrate

@openjdk openjdk bot closed this May 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@thegreystone Since your change was applied there have been 10 commits pushed to the master branch:

  • 278a95f: 7235: Some writer cleanup
  • 9852c99: 7256: Use .jcheck/conf property to control version
  • af9df26: 7201: JdkAttributes.OS_SWITCH_RATE does not work consistently across JFRs from different JDK versions.
  • d708be3: 7164: Add support for hidden classes
  • 8653337: 7241: Adjust main pom.xml to more align for 3th party builds
  • 30223c7: 7124: Support the new JDK 16 allocation profiling event
  • 917a95c: 7246: ClassCastException when opening heap dump
  • 7732a7c: 7105: Unable to open graph-view if JMC is booted with JDK 8
  • 033cc93: 6939: Time range indicator isn't updated when setting the time range
  • 84fc937: 7194: No local JVMs found message could be more helpful

Your commit was automatically rebased without conflicts.

Pushed as commit 9829c20.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the release-note-project-settings branch Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants