Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6939: Time range indicator isn't updated when setting the time range #238

Closed
wants to merge 1 commit into from

Conversation

@aptmac
Copy link
Member

@aptmac aptmac commented Apr 9, 2021

This PR addresses JMC-6939 [0], in which the time range indicator does not update when setting a time range.

The issue here is that visible range of the chart is not updated when a new range is selected. In onFlavorSelected(), the table is updated with the new selection, but the chart is not. Here I've added a line to set the visible range with the new selection values. Additionally, I've tweaked the if-statement so that when "No Selection" is selected in the flavor selector the table & chart display the default selection. Previously if the "No Selection" option was selected after viewing a different selection, because selectionItems is null there would be no update to the table or chart; now it is really showing "No Selection".

There was also a problem with the time range indicator in the flavor selector not updating properly when a selection is chosen. The issue seems to be the layout() call not resulting in a redraw of the canvas, so it has been changed to redraw() instead.

[0] https://bugs.openjdk.java.net/browse/JMC-6939

Gif examples:

Before
The table updates correctly, but the chart doesn't.
The flavor selector time range indicator doesn't redraw as expected.
6939-before

After
The chart updates to the selected time range, and the flavor selector redraws as expected.
6939-after


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6939: Time range indicator isn't updated when setting the time range

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/238/head:pull/238
$ git checkout pull/238

Update a local copy of the PR:
$ git checkout pull/238
$ git pull https://git.openjdk.java.net/jmc pull/238/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 238

View PR using the GUI difftool:
$ git pr show -t 238

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/238.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 9, 2021

👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 9, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@aptmac This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6939: Time range indicator isn't updated when setting the time range

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 9, 2021
@aptmac
Copy link
Member Author

@aptmac aptmac commented Apr 13, 2021

/integrate

@openjdk openjdk bot closed this Apr 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 13, 2021

@aptmac Since your change was applied there has been 1 commit pushed to the master branch:

  • 84fc937: 7194: No local JVMs found message could be more helpful

Your commit was automatically rebased without conflicts.

Pushed as commit 033cc93.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aptmac aptmac deleted the 6939 branch Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants