7105: Unable to open graph-view if JMC is booted with JDK 8 #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This one-liner PR addresses JMC-7105 [0], in which the GraphView is unable to open when JMC is launched with JDK 8.
The problem here is the usage of
List.of()
[1], which is supported in JDK 9+ [2], but not available in JDK 8 [3].This PR simply changes
List.of()
toArrays.asList()
to make it JDK 8 compliant.[0] https://bugs.openjdk.java.net/browse/JMC-7105
[1] https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.flightrecorder.graphview/src/main/java/org/openjdk/jmc/flightrecorder/graphview/views/GraphView.java#L186
[2] https://docs.oracle.com/javase/9/docs/api/java/util/List.html#of--
[3] https://docs.oracle.com/javase/8/docs/api/java/util/List.html
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/239/head:pull/239
$ git checkout pull/239
Update a local copy of the PR:
$ git checkout pull/239
$ git pull https://git.openjdk.java.net/jmc pull/239/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 239
View PR using the GUI difftool:
$ git pr show -t 239
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/239.diff