Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7105: Unable to open graph-view if JMC is booted with JDK 8 #239

Closed
wants to merge 1 commit into from

Conversation

aptmac
Copy link
Member

@aptmac aptmac commented Apr 9, 2021

This one-liner PR addresses JMC-7105 [0], in which the GraphView is unable to open when JMC is launched with JDK 8.

The problem here is the usage of List.of() [1], which is supported in JDK 9+ [2], but not available in JDK 8 [3].

This PR simply changes List.of() to Arrays.asList() to make it JDK 8 compliant.

[0] https://bugs.openjdk.java.net/browse/JMC-7105
[1] https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.flightrecorder.graphview/src/main/java/org/openjdk/jmc/flightrecorder/graphview/views/GraphView.java#L186
[2] https://docs.oracle.com/javase/9/docs/api/java/util/List.html#of--
[3] https://docs.oracle.com/javase/8/docs/api/java/util/List.html


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7105: Unable to open graph-view if JMC is booted with JDK 8

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/239/head:pull/239
$ git checkout pull/239

Update a local copy of the PR:
$ git checkout pull/239
$ git pull https://git.openjdk.java.net/jmc pull/239/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 239

View PR using the GUI difftool:
$ git pr show -t 239

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/239.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 9, 2021

👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 9, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 9, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 9, 2021

@aptmac This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7105: Unable to open graph-view if JMC is booted with JDK 8

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 9, 2021
@aptmac
Copy link
Member Author

aptmac commented Apr 13, 2021

/integrate

@openjdk openjdk bot closed this Apr 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 13, 2021
@openjdk
Copy link

openjdk bot commented Apr 13, 2021

@aptmac Since your change was applied there have been 2 commits pushed to the master branch:

  • 033cc93: 6939: Time range indicator isn't updated when setting the time range
  • 84fc937: 7194: No local JVMs found message could be more helpful

Your commit was automatically rebased without conflicts.

Pushed as commit 7732a7c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aptmac aptmac deleted the 7105 branch June 25, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants