Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7246: ClassCastException when opening heap dump #243

Closed
wants to merge 1 commit into from
Closed

7246: ClassCastException when opening heap dump #243

wants to merge 1 commit into from

Conversation

@tobiasstadler
Copy link
Contributor

@tobiasstadler tobiasstadler commented Apr 21, 2021

Signed-off-by: Tobias Stadler ts.stadler@gmx.de


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7246: ClassCastException when opening heap dump

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/243/head:pull/243
$ git checkout pull/243

Update a local copy of the PR:
$ git checkout pull/243
$ git pull https://git.openjdk.java.net/jmc pull/243/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 243

View PR using the GUI difftool:
$ git pr show -t 243

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/243.diff

Signed-off-by: Tobias Stadler <ts.stadler@gmx.de>
@bridgekeeper bridgekeeper bot added the oca label Apr 21, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 21, 2021

Hi @tobiasstadler, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user tobiasstadler" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2021

⚠️ @tobiasstadler a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 7732a7c5b11118f5af871e6becb43c9132962055
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@tobiasstadler
Copy link
Contributor Author

@tobiasstadler tobiasstadler commented Apr 21, 2021

/signed

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 21, 2021

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 22, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@tobiasstadler This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7246: ClassCastException when opening heap dump

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 22, 2021
@tobiasstadler
Copy link
Contributor Author

@tobiasstadler tobiasstadler commented Apr 23, 2021

/integrate

@openjdk openjdk bot added the sponsor label Apr 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@tobiasstadler
Your change (at version 88a02b6) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Apr 23, 2021

Thank you for the contribution @tobiasstadler! :)

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Apr 25, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Apr 25, 2021

@thegreystone @tobiasstadler Pushed as commit 917a95c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants