Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7242: Adding new JDK Events to core API #245

Closed
wants to merge 5 commits into from

Conversation

Suchitainf
Copy link
Collaborator

@Suchitainf Suchitainf commented May 2, 2021

This PR will address these missing events and add them to core API.

jdk.ThreadCPULoad

jdk.NativeMethodSample

jdk.ThreadStart

jdk.ThreadEnd


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7242: Adding new JDK Events to core API

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/245/head:pull/245
$ git checkout pull/245

Update a local copy of the PR:
$ git checkout pull/245
$ git pull https://git.openjdk.java.net/jmc pull/245/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 245

View PR using the GUI difftool:
$ git pr show -t 245

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/245.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2021

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 2, 2021
@mlbridge
Copy link

mlbridge bot commented May 2, 2021

Webrevs

@thegreystone thegreystone requested a review from Gunde May 3, 2021 19:51
ATTR_SYSTEM_LOAD=System Mode CPU Load
ATTR_SYSTEM_LOAD_DESC=CPU used by Thread in System mode
ATTR_USER_LOAD=User Mode CPU Load
ATTR_USER_LOAD_DESC=CPU used by Thread in User mode
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this files misses the ATTR_JAVA_THREAD and ATTR_JAVA_THREAD_DESC.

Also shouldn't this file be sorted alphabetically ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing it out. I have added that in recent commit. Regarding alphabetical sorting I have checked the file its like all ATTR_* are grouped together and then it has all AGGR_* so I have added these new values with ATTR_*. I hope that's fine.

@openjdk
Copy link

openjdk bot commented May 20, 2021

@Suchitainf this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 7242
git fetch https://git.openjdk.java.net/jmc master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the merge-conflict label May 20, 2021
@openjdk
Copy link

openjdk bot commented Jun 2, 2021

@Suchitainf This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7242: Adding new JDK Events to core API

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • fbf2d9b: 7041: Add Percentage column based on Duration in stack trace view
  • 7220aee: 7261: Enhance agent pom.xml for future library deployment
  • 6478ba9: 7258: Use the public XLST classes for the release notes
  • b273c96: 7259: README.md should mention that the build script works for Mac OS
  • 713f93e: 7070: Allow JMC to open compressed recordings with the extension .lz4

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 2, 2021
@Suchitainf
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot closed this Jun 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 2, 2021
@openjdk
Copy link

openjdk bot commented Jun 2, 2021

@Suchitainf Since your change was applied there have been 5 commits pushed to the master branch:

  • fbf2d9b: 7041: Add Percentage column based on Duration in stack trace view
  • 7220aee: 7261: Enhance agent pom.xml for future library deployment
  • 6478ba9: 7258: Use the public XLST classes for the release notes
  • b273c96: 7259: README.md should mention that the build script works for Mac OS
  • 713f93e: 7070: Allow JMC to open compressed recordings with the extension .lz4

Your commit was automatically rebased without conflicts.

Pushed as commit e3e26ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants