-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7242: Adding new JDK Events to core API #245
Conversation
👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into |
Webrevs
|
ATTR_SYSTEM_LOAD=System Mode CPU Load | ||
ATTR_SYSTEM_LOAD_DESC=CPU used by Thread in System mode | ||
ATTR_USER_LOAD=User Mode CPU Load | ||
ATTR_USER_LOAD_DESC=CPU used by Thread in User mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this files misses the ATTR_JAVA_THREAD
and ATTR_JAVA_THREAD_DESC
.
Also shouldn't this file be sorted alphabetically ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing it out. I have added that in recent commit. Regarding alphabetical sorting I have checked the file its like all ATTR_* are grouped together and then it has all AGGR_* so I have added these new values with ATTR_*. I hope that's fine.
@Suchitainf this pull request can not be integrated into git checkout 7242
git fetch https://git.openjdk.java.net/jmc master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@Suchitainf This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@Suchitainf Since your change was applied there have been 5 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit e3e26ef. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR will address these missing events and add them to core API.
jdk.ThreadCPULoad
jdk.NativeMethodSample
jdk.ThreadStart
jdk.ThreadEnd
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/245/head:pull/245
$ git checkout pull/245
Update a local copy of the PR:
$ git checkout pull/245
$ git pull https://git.openjdk.java.net/jmc pull/245/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 245
View PR using the GUI difftool:
$ git pr show -t 245
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/245.diff