Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7201: JdkAttributes.OS_SWITCH_RATE does not work consistently across JFRs from different JDK versions. #246

Closed
wants to merge 2 commits into from

Conversation

Suchitainf
Copy link
Collaborator

@Suchitainf Suchitainf commented May 5, 2021

This PR addresses the issue of switchRate attribute not accessible via core API when used for JFR generated with JDK 11 and above.

Please review the change and provide your valuable comments.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7201: JdkAttributes.OS_SWITCH_RATE does not work consistently across JFRs from different JDK versions.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/246/head:pull/246
$ git checkout pull/246

Update a local copy of the PR:
$ git checkout pull/246
$ git pull https://git.openjdk.java.net/jmc pull/246/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 246

View PR using the GUI difftool:
$ git pr show -t 246

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/246.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2021

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@Suchitainf Suchitainf changed the title JdkAttributes.OS_SWITCH_RATE does not work consistently across JFRs from different JDK versions. 7201 : JdkAttributes.OS_SWITCH_RATE does not work consistently across JFRs from different JDK versions. May 6, 2021
@Suchitainf Suchitainf changed the title 7201 : JdkAttributes.OS_SWITCH_RATE does not work consistently across JFRs from different JDK versions. 7201: JdkAttributes.OS_SWITCH_RATE does not work consistently across JFRs from different JDK versions. May 6, 2021
@openjdk openjdk bot added the rfr label May 6, 2021
@mlbridge
Copy link

mlbridge bot commented May 6, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented May 11, 2021

@Suchitainf This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7201: JdkAttributes.OS_SWITCH_RATE does not work consistently across JFRs from different JDK versions.

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • d708be3: 7164: Add support for hidden classes
  • 8653337: 7241: Adjust main pom.xml to more align for 3th party builds

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 11, 2021
Copy link
Member

@thegreystone thegreystone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Oracle type id should be defined in OracleJdkTypeIDsPre11.

@Suchitainf
Copy link
Collaborator Author

The Oracle type id should be defined in OracleJdkTypeIDsPre11.

I feel its already there at line no 181 in OracleJdkTypeIDsPre11 as below:
private final static String CONTEXT_SWITCH_RATE = JVM_EVENT_ID_ROOT + "os/processor/context_switch_rate";

Please let me know if otherwise.

@Suchitainf
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot closed this May 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 11, 2021
@openjdk
Copy link

openjdk bot commented May 11, 2021

@Suchitainf Since your change was applied there have been 2 commits pushed to the master branch:

  • d708be3: 7164: Add support for hidden classes
  • 8653337: 7241: Adjust main pom.xml to more align for 3th party builds

Your commit was automatically rebased without conflicts.

Pushed as commit af9df26.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants