-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7201: JdkAttributes.OS_SWITCH_RATE does not work consistently across JFRs from different JDK versions. #246
Conversation
…rom different JDK versions.
👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into |
Webrevs
|
@Suchitainf This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Oracle type id should be defined in OracleJdkTypeIDsPre11.
I feel its already there at line no 181 in OracleJdkTypeIDsPre11 as below: Please let me know if otherwise. |
...c/main/java/org/openjdk/jmc/flightrecorder/parser/synthetic/SyntheticAttributeExtension.java
Outdated
Show resolved
Hide resolved
/integrate |
@Suchitainf Since your change was applied there have been 2 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit af9df26. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR addresses the issue of switchRate attribute not accessible via core API when used for JFR generated with JDK 11 and above.
Please review the change and provide your valuable comments.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/246/head:pull/246
$ git checkout pull/246
Update a local copy of the PR:
$ git checkout pull/246
$ git pull https://git.openjdk.java.net/jmc pull/246/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 246
View PR using the GUI difftool:
$ git pr show -t 246
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/246.diff