Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6665: .project files still exist for removed platform definitions #25

Closed
wants to merge 1 commit into from

Conversation

@jiekang
Copy link
Contributor

jiekang commented Jan 6, 2020

Removes the .project files that remain in the directories. See 423e72d for the removal of the platform definitions.

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JMC-6665: .project files still exist for removed platform definitions

Approvers

  • Marcus Hirt (hirt - Reviewer)
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 6, 2020

👋 Welcome back jkang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Jan 6, 2020
@mlbridge
Copy link

mlbridge bot commented Jan 6, 2020

Webrevs

@openjdk openjdk bot removed the rfr label Jan 7, 2020
@openjdk
Copy link

openjdk bot commented Jan 7, 2020

@jiekang This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6665: .project files still exist for removed platform definitions

Reviewed-by: hirt
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jan 7, 2020
@jiekang
Copy link
Contributor Author

jiekang commented Jan 7, 2020

/integrate

@openjdk openjdk bot added the sponsor label Jan 7, 2020
@openjdk
Copy link

openjdk bot commented Jan 7, 2020

@jiekang
Your change (at version 0c5147e) is now ready to be sponsored by a Committer.

@aptmac
Copy link
Contributor

aptmac commented Jan 7, 2020

/sponsor

@openjdk openjdk bot closed this Jan 7, 2020
@openjdk openjdk bot added integrated and removed sponsor labels Jan 7, 2020
@openjdk
Copy link

openjdk bot commented Jan 7, 2020

@aptmac @jiekang
Pushed as commit 31d82a7.

@openjdk openjdk bot removed the ready label Jan 7, 2020
@mlbridge
Copy link

mlbridge bot commented Jan 7, 2020

Mailing list message from Alex Macdonald on jmc-dev:

Changeset: 31d82a7
Author: Jie Kang <jkang at openjdk.org>
Committer: Alex Macdonald <aptmac at openjdk.org>
Date: 2020-01-07 15:38:19 +0000
URL: https://git.openjdk.java.net/jmc/commit/31d82a7d

6665: .project files still exist for removed platform definitions

Reviewed-by: hirt

- releng/platform-definitions/platform-definition-2018-09/.project
- releng/platform-definitions/platform-definition-2018-12/.project
- releng/platform-definitions/platform-definition-2019-03/.project
- releng/platform-definitions/platform-definition-2019-06/.project

@jiekang jiekang deleted the jiekang:6665 branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.